Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ratatui to 0.26.1 #121

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Conversation

orhun
Copy link
Collaborator

@orhun orhun commented Mar 31, 2024

Also updated imports and simplified the dependency definition in Cargo.toml 🐻

@orhun
Copy link
Collaborator Author

orhun commented Mar 31, 2024

Looks like there are some layout changes:

--- STDERR:              heh::bin/heh screen::tests::test_calculate_dimensions_no_popup ---
thread 'screen::tests::test_calculate_dimensions_no_popup' panicked at src/screen.rs:495:9:
assertion `left == right` failed
  left: 22
 right: 24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Is that an issue? Should I just update the test?

an update (perhaps ratatui/ratatui@be4fdaa?) since tui 0.24 has updated the way they calculate proportions -- this commit fixes the intended dimensions and allows all of the hex and ascii to be displayed on a single line again.
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.7%. Comparing base (c77f399) to head (3917ec1).

Additional details and impacted files
Files Coverage Δ
src/character.rs 50.0% <ø> (+2.3%) ⬆️
src/screen.rs 21.9% <100.0%> (-0.3%) ⬇️
src/windows/jump_to_byte.rs 0.0% <ø> (ø)
src/windows/mod.rs 8.1% <ø> (+0.4%) ⬆️
src/windows/search.rs 47.1% <ø> (-0.5%) ⬇️
src/windows/unsaved_changes.rs 0.0% <ø> (ø)

... and 5 files with indirect coverage changes

@ndd7xv
Copy link
Owner

ndd7xv commented Mar 31, 2024

I tested and it seems like the Rect dimensions were slightly different, so the last character of each line was not being shown in the ASCII portion of the screen; I just changed that and I'm gonna merge this! Thanks!

@ndd7xv ndd7xv merged commit d41ae70 into ndd7xv:main Mar 31, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants