-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extra headers of HEAD request for container/object requests. #178
base: master
Are you sure you want to change the base?
Conversation
I'm not sure why go1.17 failed in below,
I tried to run golangci-lint looks fine in my end.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks backwards compatibility, so you'll need to introduce a new ContainerHeaders function or similar
Just add two extraheaders for container and object in connection structure. Do you think that make sense? |
I'd prefer new functions with extra parameters otherwise you create a global state which will be difficult to share between threads. |
Do you mean something likes this?
|
Hi team,
I'd like to add headers support for HEAD requests that might help in some case like
X-Newest: true
(#100) or some custom headers.Thanks!