Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and tests on updating Content-Type #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thiagodasilva
Copy link
Contributor

Newer swift no longer requires a copy in place to update content-type.

Updated a bit of the docs and added test to demonstrate the
differences in behavior when using ObjectUpdateContentType and
ObjectUpdate to update Content-Type

Signed-off-by: Thiago da Silva [email protected]

Newer swift no longer requires a copy in place to update content-type.

Updated a bit of the docs and added test to demonstrate the
differences in behavior when using ObjectUpdateContentType and
ObjectUpdate to update Content-Type

Signed-off-by: Thiago da Silva <[email protected]>
@ncw
Copy link
Owner

ncw commented Nov 12, 2019

This code looks nice too! However we have problems running the tests on older swift versions - any ideas?

@thiagodasilva
Copy link
Contributor Author

I think in this case, there's an issue with the swift emulator, here:
https://github.com/ncw/swift/blob/master/swifttest/server.go#L198,L209

It's always adding new custom metadata to an object, when in fact, whenever you post to an object, the previous custom headers are lost. This has always been the swift behavior. I'm adding a new test to clearly show the functionality.

When posting new custom metadata, the previous custom metadata
is lost.
@ncw
Copy link
Owner

ncw commented Nov 13, 2019

Looks like we are going to need a fix to the emulator to get this to pass the tests! Are you working on that?

@thiagodasilva
Copy link
Contributor Author

thiagodasilva commented Nov 14, 2019

@ncw I haven't looked at fixing the emulator yet. Having said that, would you consider running the travis ci tests against a docker saio image? I think it would make more sense that maintaining a swift emulator, thoughts?

@ncw
Copy link
Owner

ncw commented Nov 17, 2019

@ncw I haven't looked at fixing the emulator yet. Having said that, would you consider running the travis ci tests against a docker saio image? I think it would make more sense that maintaining a swift emulator, thoughts?

I think I'd like to do both - fix the emulator and run against the swift aio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants