Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registration validation (Version 2) #622

Merged

Conversation

paulandm
Copy link
Contributor

@paulandm paulandm commented Oct 1, 2024

Check to see if current user is capable of creating meetings with the registration option enabled.
It seems like only users with a 'Pro' license are capable of creating such meetings.

Check to see if current user is capable of creating meetings with the registration option
Set 'use_pmi' to false when registration is requested.
@paulandm paulandm changed the title Implement registration validation Implement registration validation (Version 2) Oct 2, 2024
@smbader smbader requested a review from jrchamp October 3, 2024 15:34
@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Oct 10, 2024
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulandm,

This looks really good! I have a few suggestions that may help. If you have any questions, please let us know.

classes/webservice.php Outdated Show resolved Hide resolved
mod_form.php Outdated Show resolved Hide resolved
mod_form.php Outdated Show resolved Hide resolved
Implemented PR feedback/suggestions.
@paulandm
Copy link
Contributor Author

Hi @jrchamp

Thanks for your feedback. I've implemented the requested changes.

Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating the changes so quickly! One quick suggestion to match the wording changes.

lang/en/zoom.php Outdated Show resolved Hide resolved
@paulandm
Copy link
Contributor Author

Thank you @jrchamp. I've implemented the requested change.

Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is an excellent fix for registration validation.

@jrchamp jrchamp merged commit 52ae1a7 into ncstate-delta:main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants