Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #557: Add SVG and PNG icon for calendar #558

Conversation

ScottVerbeek
Copy link
Contributor

@ScottVerbeek ScottVerbeek commented Jan 4, 2024

Resolves issue #557 fixing unit test test_svg_fallback on Moodle 4.3.

root@c3e2c38a9c70:/var/www/vanilla-403# vendor/bin/phpunit --filter test_svg_fallback 
Moodle 4.3.2 (Build: 20231222), 6a6043c47b80ea6f64f69d8a41487ded3444a970
Php: 8.1.24, pgsql: 14.0 (Debian 14.0-1.pgdg110+1), OS: Linux 6.4.12-060412-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

...............................................................  63 / 507 ( 12%)
............................................................... 126 / 507 ( 24%)
............................................................... 189 / 507 ( 37%)
............................................................... 252 / 507 ( 49%)
............................................................... 315 / 507 ( 62%)
............................................................... 378 / 507 ( 74%)
............................................................... 441 / 507 ( 86%)
............................................................... 504 / 507 ( 99%)
...                                                             507 / 507 (100%)

Time: 00:11.212, Memory: 344.00 MB

OK (507 tests, 507 assertions)

Fixes #557

@jrchamp jrchamp self-assigned this Jan 4, 2024
@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Jan 4, 2024
@jrchamp
Copy link
Collaborator

jrchamp commented Jan 4, 2024

Thanks @ScottVerbeek! We'll do some testing on our side and plan to merge this in the next release.

@jrchamp
Copy link
Collaborator

jrchamp commented Jan 10, 2024

Hi @ScottVerbeek, I wasn't able to push directly to your branch, so I opened catalyst#1 to optimize the SVG files. With that change added on, I'd be happy to approve and merge this tomorrow.

Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you for the PR.

@smbader
Copy link
Contributor

smbader commented Jan 11, 2024

@jrchamp will add SVGOMG optimizations in a separate pull request.

@smbader smbader merged commit 6f7ceef into ncstate-delta:main Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unit test test_svg_fallback failing in Moodle 4.3
3 participants