Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code to rebuild _ui.py and _ui_rc.py files at runtime #471

Closed
caver456 opened this issue Jul 12, 2022 · 2 comments · Fixed by #497
Closed

add code to rebuild _ui.py and _ui_rc.py files at runtime #471

caver456 opened this issue Jul 12, 2022 · 2 comments · Fixed by #497
Labels
enhancement
Milestone
system

Comments

@caver456
Copy link
Collaborator

Copy code from ncssar/plans_console repo and test. Discussed during #470
@caver456 caver456 added this to the system milestone Jul 12, 2022
@caver456 caver456 changed the title add code to rebuild _ui.py and _rc_ui.py files at runtime add code to rebuild _ui.py and _ui_rc.py files at runtime Jul 12, 2022
@caver456
Copy link
Collaborator Author

@erinn this one seems pretty low priority, maybe we leave it alone until the next time any GUI changes are planned, or until after any of the bigger projects you're looking at are done? While it wouldn't take long to do, I'm not exactly sure when I'd have time to get to it, and I don't want to interfere with other work you're doing. What do you suggest for timing of this one?

@erinn
Copy link
Contributor

erinn commented Jul 12, 2022

Depending on call volume, I'd guess mid next week for my installer work. But great thing about branches is we can reconcile this and work async, so go ahead if you like, I'll submit my changes in when possible.

caver456 added a commit that referenced this issue Sep 20, 2022
@caver456
fix #471
9b2bfbf 
mostly copied from plans_console, with some code cleanup; could be made into a shared module at some point
@caver456 caver456 linked a pull request Sep 20, 2022 that will close this issue
fix #471 #497
Merged
caver456 added a commit that referenced this issue Sep 20, 2022
@caver456
Merge pull request #497 from ncssar/471-add-code-to-rebuild-_uipy-and…
27509ca 
…-_ui_rcpy-files-at-runtime

fix #471
@caver456 caver456 mentioned this issue Oct 1, 2022
Draft
@caver456 caver456 mentioned this issue Oct 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
system
Development

Successfully merging a pull request may close this issue.

fix #471 ncssar/radiolog
2 participants
@erinn @caver456