Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliase für absolute Paths in @northware/ui und northware-cockpit #183

Merged
merged 11 commits into from
Nov 30, 2024

Conversation

onissen
Copy link
Collaborator

@onissen onissen commented Nov 30, 2024

Beschreibung

  • Innerhalb von @northware/ui ist jetzt der Alias @northare/ui für absolute Importe innerhalb des Packages konfiguriert.

Vorher

import { Label } from "./Label";

Nachher

import { Label } from "@northware/ui/components/form-parts/Label";
  • Die gleiche Konfiguration ist auch in northware-cockpit definiert, damit die imports aus dem Package funktionieren.

  • Im northware-cockpit ist außerdem der Alias @/* für absolute Imports innerhalb der App zu ermöglichen

  • Die Utility-Funktionen aus utils.ts werden jetzt unter @northware/ui/utils exportiert.

Die Path-Aliase für @northware/ui sind nun so konfiguriert, das northware-cockpit und @northware/ui sie verstehen.
…gin Logo

Das Light und Dark Logo wurden bei den falschen Themes gerendert (die If-Abfrage führte zu den flaschen Ergebnissen). Da dieses Rendering von next-themes abhängig ist muss die Image-Componente für das Logo von der Hydration ignoriert werden.
Importe von Komponenten aus northware-cockpit können innerhalb der App über @/ importiert werden.
Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: 5e42887

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added apps/northware-cockpit Anything related to Northware Cockpit packages/ui Anything related to the @northware/ui package labels Nov 30, 2024
@onissen onissen marked this pull request as ready for review November 30, 2024 23:55
@onissen onissen merged commit cf37abe into main Nov 30, 2024
6 checks passed
@onissen onissen deleted the ui/absolute-path-alias branch November 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps/northware-cockpit Anything related to Northware Cockpit packages/ui Anything related to the @northware/ui package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant