Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #551

Closed
duck-nukem opened this issue Oct 14, 2019 · 5 comments
Closed

Docker support #551

duck-nukem opened this issue Oct 14, 2019 · 5 comments
Labels
question Further information is requested

Comments

@duck-nukem
Copy link
Contributor

Hi!

I wanted to experiment with ScoutSuite, and I have created a Dockerfile so I can run it without virtualenv - is this something you might be interested in?

I'll create a PR shortly, and then you can decide if we should pursue this.

On another note, I must say ScoutSuite is quite nice, I'm quite pleased with the generated report!

@x4v13r64
Copy link
Collaborator

Happy you've found the tool useful @kreatemore.

I don't really see the benefit of leveraging docker to run ScoutSuite, considering it's pretty trivial with virtualenv/pip. Maybe I'm missing something / specific use cases?

@x4v13r64 x4v13r64 added the question Further information is requested label Oct 14, 2019
@duck-nukem
Copy link
Contributor Author

duck-nukem commented Oct 14, 2019

Thanks for the quick reply - I think it might be a highly subjective use-case, I personally prefer working in Docker, rather than having packages installed on my host.

Apart from the above - and I'm still exploring this option - it might be useful if you want to run ScoutSuite as part of an automated workflow.

The PR stands ready, if you'd like to see it, I'll submit - but if you don't feel the need for this, feel free to close this issue, and I won't create a PR

@thommor
Copy link
Contributor

thommor commented Oct 14, 2019

I don’t think it would hurt to have one.

The maintenance and upkeep of a Dockerfile is minimal.

@x4v13r64
Copy link
Collaborator

I don’t think it would hurt to have one.

Ok then @kreatemore feel free to submit a PR 😄

I personally prefer working in Docker, rather than having packages installed on my host.

That's why you use virtual environments!!!

x4v13r64 added a commit that referenced this issue Oct 15, 2019
@x4v13r64
Copy link
Collaborator

Thanks for the contribution @kreatemore, this is now merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants