-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker support #551
Comments
Happy you've found the tool useful @kreatemore. I don't really see the benefit of leveraging docker to run ScoutSuite, considering it's pretty trivial with virtualenv/pip. Maybe I'm missing something / specific use cases? |
Thanks for the quick reply - I think it might be a highly subjective use-case, I personally prefer working in Docker, rather than having packages installed on my host. Apart from the above - and I'm still exploring this option - it might be useful if you want to run ScoutSuite as part of an automated workflow. The PR stands ready, if you'd like to see it, I'll submit - but if you don't feel the need for this, feel free to close this issue, and I won't create a PR |
I don’t think it would hurt to have one. The maintenance and upkeep of a Dockerfile is minimal. |
Ok then @kreatemore feel free to submit a PR 😄
That's why you use virtual environments!!! |
Thanks for the contribution @kreatemore, this is now merged! |
Hi!
I wanted to experiment with ScoutSuite, and I have created a Dockerfile so I can run it without virtualenv - is this something you might be interested in?
I'll create a PR shortly, and then you can decide if we should pursue this.
On another note, I must say ScoutSuite is quite nice, I'm quite pleased with the generated report!
The text was updated successfully, but these errors were encountered: