Add a natural language selector to the ontology submission form #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jvendetti, we used this gem https://github.com/xwmx/iso-639, to provide a list of all iso-639-1 languages, with it you will not need to have a local |
|
Modified the pull request to replace the YAML file containing ISO 639-1 language codes with the iso-639 gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a YAML file with the ISO 639-1 language codes, makes the codes available via the Rails config object (
Rails.application.config.language_codes), and adds a Select2-based natural language selector to the ontology submission form. Resolves #311.I'm not totally happy with this implementation, but attempts to modernize / align with AgroPortal by adopting the Tom Select library stalled out. See this issue, and this pull request comment for more details. I'd like to revisit this implementation after I have time to sort out blockers to adopting Tom Select.