Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDB-5087: bitmagick patch #27

Merged
merged 2 commits into from
Nov 17, 2022
Merged

VDB-5087: bitmagick patch #27

merged 2 commits into from
Nov 17, 2022

Conversation

oshutov
Copy link
Collaborator

@oshutov oshutov commented Nov 7, 2022

No description provided.

@aboshkin
Copy link
Contributor

aboshkin commented Nov 8, 2022

@oshutov The change looks OK, but I see a failing test:
{noformat}
ngs-tools/tools/tax> make test
...
2: Test command: /home/boshkins/ncbi-outdir/ngs-tools/linux/gcc/x86_64/dbg/bin/reader_test
2: Test timeout computed to be: 10000000
2: Running 2 tests
2: Running test fasta_reader
2: /home/boshkins/ncbi/devel/ngs-tools/tools/tax/src/tests/reader_test.cpp:111: void fasta_reader(): Assertion 'f.spotid' == '"SRR1068106.1 1 length=499"' failed.
2: SRR1068106.1 != SRR1068106.1 1 length=499
2/3 Test #2: reader_test ......................Child aborted***Exception: 0.01 sec
...
{noformat}
All tests pass in engineering.
This is on a non-NCBI Ubuntu.

@aboshkin
Copy link
Contributor

aboshkin commented Nov 8, 2022

Looks good to me. Will merge once we unfreeze engineering, in a few days.

@aboshkin aboshkin merged commit 1246778 into engineering Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants