Sync with dotnet/fsharp 2021-11-12 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alfonsogarciacaro Closing this, it was merged separately. Sorry I couldn't keep your commit as is because of the rebasing, but I attributed you in the commit message. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ncave I think you prefer rebasing, but it was difficult to fix all the conflicts so the PR includes some merge commits. Also, I removed
ParseFilefrom service_slim because I didn't need and I wasn't sure how to fix the build errors, but please feel free to re-add it for completenees (in that case, probablyParseAndCheckFileInProjectshould takesourceReader: string -> int * Lazy<string>as parameter instead of the full list of sources).Besides that and the changes to keep up with FCS
I just parallelized the parsing phase in.ParseAndCheckProject