✨ Update authentication scheme #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users can specify --tfa-2-pass if remote machine requires users to type in two passwords (e.g. google authenticate)
Removed password from connect_kwargs and now use auth_interactive_dumb() for all interactive prompts... so I removed the --tfa-2-pass option and now any BadAuthenticationType exceptions (whether missing password or missing password and 2FA) will prompt users for input. Note that these prompts will always go through getpass, so even things like username will not be mirrored on stdout.
andersy005
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
This looks great 👍... I'm going to wait for @rmg55's confirmation that this is working properly before merging...
|
This solved the authentication issue I raised in #49 . Thanks of bunch @andersy005 and @mnlevy1981 |
|
Many thanks @mnlevy1981 & @rmg55! Merging this.... |
andersy005
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than rely on
connect_kwargs['password']to send password toConnection, use a lightweight handler that is basically a lightweight version of the example in https://stackoverflow.com/a/43943658. This has the added bonus of the password prompt reflecting what you get fromssh... e.g. Casper requestsToken_Response:and if you have your ssh keys configured to avoid requiring a password then you should no longer get any prompt at all (rather than a prompt that is not actually passed to the host).Fixes #49