-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch jlab with asynchronous=True #4
Conversation
I opted to name the |
@andersy005 I ran into errors the two times I tried to run your script:
Note that
The process was still running on
That's the error I was getting when I put the 1 second sleep in, and I'm surprised your |
In that case, allow the UnexpectedExit exception
7bf6b0c resolves the second error I was seeing:
|
There were instances where an old copy of logfile was picked up by tail and then the wrong information was printed to stdout
Fallback is to use $HOME, otherwise use '~'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @mnlevy1981 ! I am going to merge it. If there's anything missing, we can revisit in a separate PR.
I think piping the output to a log file is necessary so we can grab the port and token; for now I'm just printing the log file to
stdout
in a separate run command to show thatasynchronous
is working correctly.Fixes #3