Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with CESM history file times in more generic way #22

Merged
merged 3 commits into from
May 27, 2021

Conversation

mgrover1
Copy link
Contributor

Helps with #21

  • Changes use of cf_xarray time dimension call to use T instead of time to find time variable name
  • Includes try-except block to grab time bound information, if it isn't there (as in CISM), feeds empty string which still allows searching for variables with time dimension, dropping time and time bound variables

@mgrover1 mgrover1 requested a review from andersy005 May 27, 2021 15:01
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @mgrover1!

@andersy005 andersy005 merged commit b8961bb into ncar-xdev:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants