Integration tests with bitcoin in regtest mode #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afk11
force-pushed
the
rpc-integration-test
branch
from
6631d13 to
d98de4d
Compare
|
Any idea why the tests aren't running? @JoshuaEstes |
afk11
force-pushed
the
rpc-integration-test
branch
from
d98de4d to
beeec07
Compare
|
Bump :) Any thoughts either way about this one? Just remembered it was open. I can add tests covering more cases if you'd like them, for now this PR is probably incomplete (a poc for now) I actually made a package for spawning regtest nodes now, so can refactor out that stuff from here. |
|
Not sure why, it's something I'll need to look into once I get the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing this for your consideration - noticed some weird errors from bitcoind when you send an unknown RPC command, figured it could be interesting to run integration tests against bitcoind for certain cases. For now it's just a small test that the client gets something back from the server.
It's a separate issue for now, my motivation towards this kind of test is it allows us to test the library against a spectrum of bitcoind versions eventually. We could consider adding handling of bitcoind errors (named exceptions for the various error codes), and at least remain sure that we've implemented the right stuff.
Let me know what you think!