-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/multi select #1
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不多写了,整体的实现思路就有问题。
这些特性化的样式,应该添加一个新的变量来进行控制(对于 css 来说就是一个额外的平级 class)
如果修改全局的样式将对原有内容产生不可预知的改动。
background-color: mix($--tag-info-color, $--color-white, $backgroundColorWeight); | ||
border-color: mix($--tag-info-color, $--color-white, $borderColorWeight); | ||
color: mix($--tag-info-color, $--color-white, $fontColorWeight); | ||
background-color: $--cascader-tag-background-opacity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag 不能修改全局的,没出问题是因为我们的项目中有所复写。
本质上这样将特定的需求改在全局的内容是非常不合适的。
// color: mix($--tag-info-color, $--color-white, $fontColorWeight); | ||
color: $--custom-color-primary; | ||
background-color: unset; | ||
font-weight: 900; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在全局 tag 上修改 font-weight 不合适
&:hover { | ||
color: $--color-white; | ||
background-color: mix($--tag-info-color, $--color-white, $hoverColorWeight); | ||
background-color: unset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么是 unset?这里是全局的 tag
@@ -15,6 +15,9 @@ $--color-transition-base: color .2s cubic-bezier(.645,.045,.355,1) !default; | |||
|
|||
/* Color | |||
-------------------------- */ | |||
// custom Color | |||
$--custom-color-primary: #898eff !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个值可以通过外面覆盖
@@ -32,14 +32,16 @@ | |||
.el-icon-arrow-down { | |||
transition: transform .3s; | |||
font-size: 14px; | |||
font-weight: 900; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同理,font-weight 在这里修改不合适
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.