Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an initial default.nix that can build webdriver-w3c. #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanparsons
Copy link

This is a very early cut of a file that'll get webdriver-w3c to be built via nix, so it can be built with just nix-build . in the root of the project and it'll do all the heavy lifting.

The only particularly unusual thing is the dontCheck wrapper around script-monad and webdriver-w3c which just prevents their test suites from being built and run. For script-monad this is because it attempts to make a network call which nix prevents so that builds can't break the reproducibility of the build. Similarly the webdriver-w3c test suite relies on instances of geckodriver and chromedriver. Both of those projects could do with a build flag that disable any tests which rely on those and then eventually get these packages flagged as good in nixpkgs with that flag set.

@nbloomf
Copy link
Owner

nbloomf commented Aug 21, 2022

Thank you for making this PR! I don't know much about Nix and this will be a good excuse to learn.

Leaving a note for my future self: look into splitting up the test suites to isolate the ones that make nix cranky.

@fzhulitov fzhulitov mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants