-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This version of fantomas doesn't crash anymore when formatting it: dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.0.0-alpha-012 Source will be formatted using this command: fantomas --recurse src/GWallet.Backend/ Things that would need to be fixed manually before merging this to master: - We can drop parens in many if statements, e.g.: StratumClient.fs' CreateVersion's, ServerManager.fs' GetDummyBalanceAction, FTPC.fs' FTPC type, EtherAccount.fs' GetTransactionCount - Drop parents in ReadAllText calls of Account.fs - Many raise lines should use <|, e.g. in WarpKey.fs, UtxoCoinAccount.fs, and ElectrumServer.fs - UtxoCoinAccount.fs' EstimateFees unneeded use of |> with 'head' Fantomas issues from geewallet's wishlist: - fsprojects/fantomas#712 - fsprojects/fantomas#908 - fsprojects/fantomas#684 Issues not yet reported: - PageWidth not being respected? look at how long some lines in UtxoCoinAccount.fs' GetAccountFromFile are. - UtxoCoinAccount.fs' TransactionOutpoint.ToCoin() should start on next line. - UtxoCoinAccount.fs' SignTransactionWithPrivateKey has some if lines splitted weirdly, e.g. cut off at <> operator - UtxoCoin/TransactionTypes.fs' Currency member is split in 2 lines, why? - Why cut `truncated` var assignment in Formatting.fs' DecimalAmountTruncating func? - inherit statements should add a space too (look at FaultTolerantParallelClient.fs) - FaultTolerantParallelClient.fs' Runner.Run is tooooooo long - Moving commend comment of FTPC.fs' CustomCancelSource's Dispose func - (Investigate) FSharpUtil.option{} that contains a `do! if...`, WAT - Cutting function after `+` in short line (Account.fs function SaveOutgoingTransactionInCache Last but not least, investigate if alpha-012 contains unwanted things like 311bff817f89f8b47c0799eb7474da886175ef15, otherwise we might need to go back to 04c48d5, which should be alpha-011 with these fantomas-config.json settings: { "IndentSpaceNum":4, "PageWidth":80, "SemicolonAtEndOfLine":false, "SpaceBeforeParameter":true, "SpaceBeforeLowercaseInvocation":true, "SpaceBeforeUppercaseInvocation":true, "SpaceBeforeClassConstructor":true, "SpaceBeforeMember":true, "SpaceBeforeColon":false, "SpaceAfterComma":true, "SpaceBeforeSemicolon":false, "SpaceAfterSemicolon":true, "IndentOnTryWith":true, "SpaceAroundDelimiter":true, "MaxIfThenElseShortWidth":0, "MaxRecordWidth":0, "MaxFunctionBindingWidth":0, "MaxValueBindingWidth":80, "MultilineBlockBracketsOnSameColumn":true, "NewlineBetweenTypeDefinitionAndMembers":true, "KeepIfThenInSameLine":true, "StrictMode":false }
- Loading branch information
Showing
39 changed files
with
3,661 additions
and
2,972 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
[*.fs] | ||
indent_size=4, | ||
max_line_length=80, | ||
fsharp_semicolon_at_end_of_line=false | ||
fsharp_space_before_parameter=true | ||
fsharp_space_before_lowercase_invocation=true | ||
fsharp_space_before_uppercase_invocation=true | ||
fsharp_space_before_class_constructor=true | ||
fsharp_space_before_member=true | ||
fsharp_space_before_colon=false | ||
fsharp_space_after_comma=true | ||
fsharp_space_before_semicolon=false | ||
fsharp_space_after_semicolon=true | ||
fsharp_indent_on_try_with=true | ||
fsharp_space_around_delimiter=true | ||
fsharp_max_if_then_else_short_width=0 | ||
fsharp_max_record_width=0 | ||
fsharp_max_function_binding_width=0 | ||
fsharp_max_value_binding_width=80 | ||
fsharp_multiline_block_brackets_on_same_column=true | ||
fsharp_newline_between_type_definition_and_members=true | ||
fsharp_keep_if_then_in_same_line=true | ||
fsharp_strict_mode=false |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.