Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: remove the commit fee clamp, add max fee #29

Open
wants to merge 3 commits into
base: geewalletLightningMilestone12
Choose a base branch
from
Open

Core: remove the commit fee clamp, add max fee #29

wants to merge 3 commits into from

Commits on Apr 12, 2023

  1. EventAggregator.Tests: use hardcoded dep version 

    This commit fixes the issue caused by YoloDev.Expecto.TestSdk
upgrade to netcoreapp3.1.
    @aarani
    aarani committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7e2e657 View commit details
    Browse the repository at this point in the history

  2. drop inline static methods from LNMoney.Satoshis 

    Since compiler sometimes complains that it doesn't know which overload to use.
Instead we just prepare constructors for each integral types.

Might be related to dotnet/fsharp#1565
    @joemphilips @aarani
    joemphilips authored and aarani committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    53d4128 View commit details
    Browse the repository at this point in the history

  3. Core: remove the commit fee clamp, add max fee 

    This commit removes the check that compares mutual
close fee with commit tx fee, this check is outdated
and has been changed by this spec PR [1].

To prevent unreasonably high fee, this commit introduces
MutualCloseMaxFeeMultiplier setting.

[1] lightning/bolts#847
    @aarani
    aarani committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    cd8f3b8 View commit details
    Browse the repository at this point in the history