Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build script (and feature flags) #31

Merged
merged 15 commits into from
Oct 19, 2020
Merged

Conversation

nbigaouette
Copy link
Owner

@nbigaouette nbigaouette commented Oct 17, 2020

  • Since bindgen generated files are platform dependants, they are moved to their own directory onnxruntime-sys/src/generated/<os>/<arch>/bindings.rs.
  • Feature flags reworked:
    • disable-sys-build-script: Disable build script, used only for docs.rs
    • generate-bindings: Generate the bindings using bindgen. This removes the need for its compilation (since bindings are committed).
  • To generate the bindings (f.e. on version update or different platform): cargo build --package onnxruntime-sys --features generate-bindings

@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #31 into master will decrease coverage by 6.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   19.18%   13.01%   -6.17%     
==========================================
  Files          17       18       +1     
  Lines         610      899     +289     
==========================================
  Hits          117      117              
- Misses        493      782     +289     
Impacted Files Coverage Δ
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de15a0...bfcfd95. Read the comment docs.

* Don't use bindgen as dependency if not used.
* Split 'disable-bindgen' into 'disable-sys-build-script' and 'generate-bindings'
@nbigaouette nbigaouette changed the title Split autogenerated Refactor build script Oct 18, 2020
@nbigaouette nbigaouette changed the title Refactor build script Refactor build script (and feature flags) Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants