Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 블로그 네임 유효성 추가 및 url 조작중 블로그 등록 완료 불가 처리 #202 #207 #208

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Fix] 블로그 네임 유효성 추가 및 url 조작중 블로그 등록 완료 불가 처리 #202 #207 #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d932dd
fix: 블로그 네임 유효성 추가 및 url 조작중 블로그 등록 완료 불가 처리
wjdehdry3 Nov 15, 2023
3f1db70
fix: rss 유효성 검사 엔터 or 다른곳 터치 시에만 작동
wjdehdry3 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 48 additions & 22 deletions TILApp/Views/MyProfileViewController/BlogRegisterViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ final class BlogRegisterViewController: UIViewController, UIGestureRecognizerDel
var onRegistered: (() -> Void)?
private var validated = false
private var selectTextTag = 0
private var beforeChar = ""
private let blogViewModel = BlogViewModel.shared
private let keywordInputViewModel = KeywordInputViewModel.shared

Expand Down Expand Up @@ -192,9 +193,11 @@ final class BlogRegisterViewController: UIViewController, UIGestureRecognizerDel
if validateBlogName(from: blogURLTextField.mainText, to: urlString) {
validated = true
updateBlogRSSField(with: urlString)
updateDoneButtonState()
} else {
validated = false
updateBlogRSSField(with: urlString)
updateDoneButtonState()
}
}
}
Expand All @@ -203,33 +206,35 @@ final class BlogRegisterViewController: UIViewController, UIGestureRecognizerDel
guard let self else { return }
validated = false
updateBlogRSSField(with: urlString)
updateDoneButtonState()
}
}
}
task.resume()
updateBlogRSSField(with: urlString)
}
}

// TODO: 키보드 url로 변경해주기
extension BlogRegisterViewController: UITextFieldDelegate {
func textFieldShouldReturn(_ textField: UITextField) -> Bool {
let rssTextField = contentView.viewWithTag(2) as? UITextField
let urlTextField = contentView.viewWithTag(1) as? UITextField
guard let rssText = rssTextField!.text else { return false }
guard let urlText = urlTextField!.text else { return false }
var rssText = blogRSSTextField.mainText
var urlText = blogURLTextField.mainText
var nameText = blogNameTextField.mainText
guard let convertRss = convertToRssUrl(from: urlText) else { return false }
guard let convertBlog = convertToBlogUrl(from: urlText) else { return false }

if let currentText = textField.text {
switch textField.tag {
case 0:
textField.resignFirstResponder()
(contentView.viewWithTag(textField.tag + 1) as? UITextField)?.becomeFirstResponder()
updateBlogNameField(with: nameText)
case 1:
textField.resignFirstResponder()
(contentView.viewWithTag(textField.tag + 1) as? UITextField)?.becomeFirstResponder()

rssTextField?.text = convertToRssUrl(from: urlText)
urlTextField?.text = convertToBlogUrl(from: urlText)
updateBlogURLField(with: urlText)
rssText = convertRss
urlText = convertBlog

case 2:
textField.resignFirstResponder()
Expand All @@ -253,17 +258,20 @@ extension BlogRegisterViewController: UITextFieldDelegate {

func textFieldDidEndEditing(_ textField: UITextField) {
if let currentText = textField.text {
let rssTextField = contentView.viewWithTag(2) as? UITextField
let urlTextField = contentView.viewWithTag(1) as? UITextField
guard let rssText = rssTextField!.text else { return }
guard let urlText = urlTextField!.text else { return }
var rssText = blogRSSTextField.mainText
var urlText = blogURLTextField.mainText
var nameText = blogNameTextField.mainText
guard let convertRss = convertToRssUrl(from: urlText) else { return }
guard let convertBlog = convertToBlogUrl(from: urlText) else { return }

switch textField.tag {
case 0:
updateBlogNameField(with: nameText)
case 1:
(contentView.viewWithTag(textField.tag + 1) as? UITextField)?.becomeFirstResponder()

rssTextField?.text = convertToRssUrl(from: urlText)
urlTextField?.text = convertToBlogUrl(from: urlText)
rssText = convertRss
urlText = convertBlog

selectTextTag = textField.tag + 1
updateBlogURLField(with: urlText)
Expand All @@ -277,6 +285,18 @@ extension BlogRegisterViewController: UITextFieldDelegate {
updateDoneButtonState()
}

func blogNameChecker(string: String, currentText: String) {
if beforeChar == string {
blogNameTextField.isValid = false
blogNameTextField.validationText = "입력창 조작중엔 등록이 불가능합니다.(최소 1자)"
updateDoneButtonState()
}
beforeChar = string
if string != "" {
updateBlogNameField(with: currentText + string)
}
}

func textField(
_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String
) -> Bool {
Expand All @@ -285,16 +305,21 @@ extension BlogRegisterViewController: UITextFieldDelegate {
if let currentText = textField.text {
switch textField.tag {
case 0:
updateBlogNameField(with: currentText)
blogNameChecker(string: string, currentText: currentText)
case 1:
if let rssUrl = convertToRssUrl(from: currentText + string) {
rssTextField?.text = rssUrl
if string != "" {
if let rssUrl = convertToRssUrl(from: currentText + string) {
rssTextField?.text = rssUrl
}
updateBlogURLField(with: currentText + string)
}
updateBlogURLField(with: currentText + string)
case 2:
if string != "" {
urlEffectiveness(urlString: currentText + string)
if beforeChar == string {
blogRSSTextField.isValid = false
blogRSSTextField.validationText = "입력창 조작중엔 등록이 불가능합니다."
updateDoneButtonState()
}
beforeChar = string
default:
break
}
Expand All @@ -303,13 +328,14 @@ extension BlogRegisterViewController: UITextFieldDelegate {
}

func updateBlogNameField(with text: String) {
if text.isEmpty {
if text.isEmpty || text.count < 1 {
blogNameTextField.isValid = false
blogNameTextField.validationText = ""
blogNameTextField.validationText = "유효하지 않은 블로그 이름입니다.(최소 1자)"
} else {
let isDuplicate = blogViewModel.hasBlogName(text)
blogNameTextField.isValid = !isDuplicate
blogNameTextField.validationText = isDuplicate ? "이미 등록된 블로그 이름입니다." : "유효한 블로그 이름입니다."
updateDoneButtonState()
}
}

Expand Down