-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce GitHub actions #1162
base: trunk
Are you sure you want to change the base?
Introduce GitHub actions #1162
Conversation
@mvglasow @jandegr could you make sense of this Lint Error? https://github.com/navit-gps/navit/pull/1162/checks?check_run_id=3802624465 i looked it up, but its apparently a error in the Linter with some Versions. But i don't see any config where we directly define the Linter Version used. |
Lint apparently complains because it expects to see a non-negative argument for This might not be the most elegant way of coding it. A way to get rid of the lint warning would be something like:
If someone wants to take a stab a this, feel free – I can’t currently dedicate much time to Navit (unfortunately). |
e88c52e
to
981b5d0
Compare
8a3d4a1
to
87ceff3
Compare
f29485b
to
a1a9c58
Compare
This is relevant as currenly RPs from Users are not build on CircleCI which is quite useless to have PRs not beeing able to be tested reliably
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 65268d1.
02a1696
to
1bf73b0
Compare
This is the first take on Github Actions. The goal is to migrate all our builds to it as CircleCI has issues for a long time.
The most prominent is that when opening a PR no Builds are done, or those are not reported back to Github Checks.
On the other Hand Github Actions is obviously perfectly integrated and therefor has additional advantages, like allowing to start workfows, suggestins and many more.
Some of those will be integrated into this PR. The first and most notable one will be that the Build Sanity Check will now post Formatting errors back to the Contributor (within the PR) so that they can be applied with a single click.