attr_search remove unused arg #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoan
force-pushed
the
attr_search_remove_unused_arg
branch
from
8306ccb to
514228a
Compare
jkoan
force-pushed
the
attr_search_remove_unused_arg
branch
from
f2f8f9d to
d17fbf8
Compare
|
Merging this because nobody is concerned. CI also passed here: https://app.circleci.com/pipelines/github/jkoan/navit/13/workflows/1795a523-7b96-478b-b2f5-579c980932fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused argument from attr_search which can be confusing for new users and is totally unnecessary .
Merge: Dont Squash -> Rebase and Merge because it contains individual commits for multiple things but those are required because of the ci sanity check. See individual commits if in doubt.