Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/landingsside for bankid palogging som feiler #3706

Merged
merged 17 commits into from
Dec 20, 2024

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Dec 19, 2024

No description provided.

#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service

Updated several create methods across services, controllers, and consumers to return Mono instead of Flux, improving consistency and aligning with single-object processing. Also adjusted method calls and naming conventions to reflect the changes.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service

Changed the handling of authorized parties to include subunits by flattening the structure. Updated methods to use `Flux` for better reactive stream handling and improved filtering logic. This ensures more accurate processing of organizational access data.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service

Removed redundant filtering on organization numbers and added logging for each processed organization. This improves code readability and facilitates debugging by providing more insight into the processing steps. The unused filter logic has been commented out for potential future reference.
#deploy-idporten-frontend
…n3-tilgang-service-prod #deploy-altinn3-tilgang-service

Removed unnecessary mapping and flattening of subunits from the organization processing pipeline. This simplifies the logic and improves readability without affecting the core functionality. Adjustments focus on streamlining filters and data transformation.
#deploy-bruker-service

Enhanced OAuth2 settings across profiles to support different issuers and audiences. Implemented a WebFilter in `OpenApiConfig` to rewrite `/swagger` requests to `/swagger-ui.html`. This ensures proper handling of security and improves Swagger accessibility.
…loy-bruker-service

Removed an unused `TOKEN_X_CLIENT_ID` configuration from the local application YAML file. Added `AAD_ISSUER_URI` to the test application YAML file for authentication testing purposes.
…oy-bruker-service

The `AAD_ISSUER_URI` configuration was moved to the main `application.yml` file to centralize its definition. It was removed from `application-local.yml` and `application-test.yml` to avoid redundancy and potential inconsistencies across environment-specific files.
…roxy-altinn3-tilgang

Removed `dolly-frontend-dev` and `dolly-frontend-dev-unstable` applications and added `testnav-bruker-service`. This ensures the configuration aligns with the current application usage and reduces unnecessary entries.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service

Removed unnecessary applications from the accessPolicy rules in both dev and prod configurations to reflect changes in requirements. Added `testnav-bruker-service-dev` to dev inbound rules for enhanced service access support.
Refactor to use Altinn3 API for user access management
#deploy-bruker-service

Replaced Person-Organisasjon-Tilgang API with Altinn3 API across the application. Deprecated `OrganisasjonDTO` and updated classes to utilize `AltinnBrukerRequest` and Altinn3 DTOs. Adjusted configuration and consumer logic to align with the new API structure for improved functionality.
```
@krharum krharum marked this pull request as ready for review December 20, 2024 10:02
@krharum krharum requested a review from a team as a code owner December 20, 2024 10:02
#deploy-bruker-service

Simplified and corrected the TOKEN_X token mapping logic by replacing the use of `ObjectMapper` and error handling with direct attribute access. This improves clarity and reduces potential processing errors.
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir flott å få på plass dette 😄

#deploy-bruker-service

Revised class imports in `GetAuthenticatedResourceServerType` for better clarity and organization. Updated `application.yml` and associated config files to rename and refactor service property names and access rules, ensuring alignment with naming conventions and system requirements. These changes enhance maintainability and support configuration consistency.
#deploy-bruker-service

Revised the service URL in application.yml to point to the correct 'testnav-altinn3-tilgang-proxy' endpoint. This ensures proper routing and access within the dev-gcp cluster namespace.
@krharum krharum merged commit d2cc324 into master Dec 20, 2024
7 checks passed
@krharum krharum deleted the feature/landingsside-for-bankid-palogging-som-feiler branch December 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants