-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/landingsside for bankid palogging som feiler #3706
Merged
krharum
merged 17 commits into
master
from
feature/landingsside-for-bankid-palogging-som-feiler
Dec 20, 2024
Merged
Feature/landingsside for bankid palogging som feiler #3706
krharum
merged 17 commits into
master
from
feature/landingsside-for-bankid-palogging-som-feiler
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service Updated several create methods across services, controllers, and consumers to return Mono instead of Flux, improving consistency and aligning with single-object processing. Also adjusted method calls and naming conventions to reflect the changes.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service Changed the handling of authorized parties to include subunits by flattening the structure. Updated methods to use `Flux` for better reactive stream handling and improved filtering logic. This ensures more accurate processing of organizational access data.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service Removed redundant filtering on organization numbers and added logging for each processed organization. This improves code readability and facilitates debugging by providing more insight into the processing steps. The unused filter logic has been commented out for potential future reference.
This reverts commit 2df3958.
…n3-tilgang-service-prod #deploy-altinn3-tilgang-service Removed unnecessary mapping and flattening of subunits from the organization processing pipeline. This simplifies the logic and improves readability without affecting the core functionality. Adjustments focus on streamlining filters and data transformation.
#deploy-bruker-service Enhanced OAuth2 settings across profiles to support different issuers and audiences. Implemented a WebFilter in `OpenApiConfig` to rewrite `/swagger` requests to `/swagger-ui.html`. This ensures proper handling of security and improves Swagger accessibility.
…loy-bruker-service Removed an unused `TOKEN_X_CLIENT_ID` configuration from the local application YAML file. Added `AAD_ISSUER_URI` to the test application YAML file for authentication testing purposes.
…oy-bruker-service The `AAD_ISSUER_URI` configuration was moved to the main `application.yml` file to centralize its definition. It was removed from `application-local.yml` and `application-test.yml` to avoid redundancy and potential inconsistencies across environment-specific files.
…roxy-altinn3-tilgang Removed `dolly-frontend-dev` and `dolly-frontend-dev-unstable` applications and added `testnav-bruker-service`. This ensures the configuration aligns with the current application usage and reduces unnecessary entries.
#deploy-altinn3-tilgang-service-prod #deploy-altinn3-tilgang-service Removed unnecessary applications from the accessPolicy rules in both dev and prod configurations to reflect changes in requirements. Added `testnav-bruker-service-dev` to dev inbound rules for enhanced service access support.
Refactor to use Altinn3 API for user access management #deploy-bruker-service Replaced Person-Organisasjon-Tilgang API with Altinn3 API across the application. Deprecated `OrganisasjonDTO` and updated classes to utilize `AltinnBrukerRequest` and Altinn3 DTOs. Adjusted configuration and consumer logic to align with the new API structure for improved functionality. ```
#deploy-bruker-service Simplified and corrected the TOKEN_X token mapping logic by replacing the use of `ObjectMapper` and error handling with direct attribute access. This improves clarity and reduces potential processing errors.
stigus
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blir flott å få på plass dette 😄
#deploy-bruker-service Revised class imports in `GetAuthenticatedResourceServerType` for better clarity and organization. Updated `application.yml` and associated config files to rename and refactor service property names and access rules, ensuring alignment with naming conventions and system requirements. These changes enhance maintainability and support configuration consistency.
#deploy-bruker-service Revised the service URL in application.yml to point to the correct 'testnav-altinn3-tilgang-proxy' endpoint. This ensures proper routing and access within the dev-gcp cluster namespace.
krharum
deleted the
feature/landingsside-for-bankid-palogging-som-feiler
branch
December 20, 2024 11:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.