change/opensearch_config_cleanup #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nings in tooling (read: IntelliJ).
- Client credentials are now manually asserted to be non-null.
# Conflicts: # apps/dolly-backend/src/main/resources/application-local.yml # apps/oppsummeringsdokument-service/src/main/resources/application-local.yml # libs/security-core/src/main/java/no/nav/testnav/libs/securitycore/domain/azuread/AzureNavClientCredential.java
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fjernet bruk av en unødvendig secret knyttet til OpenSearch, og har omformattert referanser til config for å matche et pattern:
DEFINERES_SOM_DETTEøverst i .yml.defineres.som: dettei .yml.Det er avdekket noe problemer knyttet til
ClientCredential- har skrevet opp en TODO ino.nav.testnav.libs.securitycore.domain.azuread.AzureNavClientCredentialslik at det i hvert fall er beskrevet kodenært. Vurderer at dette krever en større omskrivning helt utenfor scope av denne PRen, evt. et tonn av unødvendige dummy-verdier iapplication-test.yml. Løst her med SPeL.Som en konsekvens vil alle applikasjoner som mangler AZURE_APP_CLIENT_[ID|SECRET] heretter feile ved oppstart, med melding om hva som mangler i config.