-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/toggle i fieldarray #3671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigus
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette blir fantastisk; en saftig julepresang av bugfix og toggle forbedringer, hva mer kan man ønske seg 🤩 🎄 🎁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to improve code quality, refactor components, and fix minor issues in the
dolly-frontend
application. The most important changes are grouped by theme and listed below:Code Quality Improvements:
BestillingKriterieMapper.tsx
to use optional chaining forforetaksNavn
to prevent potential runtime errors.nyFullmektig
to the initial fullmakt object inPersoninformasjon.tsx
to ensure the new fullmektig is included in the initial values.Refactoring:
getEgneOrganisasjoner
import toutils/EgneOrganisasjoner
inForm.tsx
andarbeidsforholdToggle.tsx
for better code organization. [1] [2]toggleValues
witharbeidsgiverToggleValues
inarbeidsforholdToggle.tsx
to use a centralized utility for toggle values. [1] [2] [3]StyledAlert
andwarningMessage
fromarbeidsforholdToggle.tsx
to clean up unused code. [1] [2]Component Simplification:
OrgMiljoeInfoVisning.tsx
component as it is no longer needed.React.Fragment
with shorthand syntax inenheterForm.tsx
andpersonrollerForm.tsx
for consistency and readability. [1] [2]Bug Fixes:
organisasjonTextSelect.tsx
to ensure proper error messages and value updates. [1] [2]useEffect
to updateinputType
based on organization data inorgnrToggle.tsx
to ensure the correct input type is set dynamically. [1] [2]Import and Dependency Updates:
React
import in several files to ensure proper JSX transformation. [1] [2] [3]