Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/toggle i fieldarray #3671

Merged
merged 23 commits into from
Dec 9, 2024
Merged

Bugfix/toggle i fieldarray #3671

merged 23 commits into from
Dec 9, 2024

Conversation

betsytraran
Copy link
Contributor

@betsytraran betsytraran commented Nov 15, 2024

This pull request includes various changes to improve code quality, refactor components, and fix minor issues in the dolly-frontend application. The most important changes are grouped by theme and listed below:

Code Quality Improvements:

  • Modified BestillingKriterieMapper.tsx to use optional chaining for foretaksNavn to prevent potential runtime errors.
  • Added nyFullmektig to the initial fullmakt object in Personinformasjon.tsx to ensure the new fullmektig is included in the initial values.

Refactoring:

  • Moved getEgneOrganisasjoner import to utils/EgneOrganisasjoner in Form.tsx and arbeidsforholdToggle.tsx for better code organization. [1] [2]
  • Replaced toggleValues with arbeidsgiverToggleValues in arbeidsforholdToggle.tsx to use a centralized utility for toggle values. [1] [2] [3]
  • Removed StyledAlert and warningMessage from arbeidsforholdToggle.tsx to clean up unused code. [1] [2]

Component Simplification:

  • Deleted the OrgMiljoeInfoVisning.tsx component as it is no longer needed.
  • Replaced React.Fragment with shorthand syntax in enheterForm.tsx and personrollerForm.tsx for consistency and readability. [1] [2]

Bug Fixes:

  • Fixed the handling of form errors and value setting in organisasjonTextSelect.tsx to ensure proper error messages and value updates. [1] [2]
  • Added useEffect to update inputType based on organization data in orgnrToggle.tsx to ensure the correct input type is set dynamically. [1] [2]

Import and Dependency Updates:

  • Added missing React import in several files to ensure proper JSX transformation. [1] [2] [3]

@betsytraran
Copy link
Contributor Author

@betsytraran betsytraran marked this pull request as ready for review December 6, 2024 14:27
@betsytraran betsytraran requested a review from a team as a code owner December 6, 2024 14:27
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette blir fantastisk; en saftig julepresang av bugfix og toggle forbedringer, hva mer kan man ønske seg 🤩 🎄 🎁

@betsytraran betsytraran merged commit 06f40a7 into master Dec 9, 2024
76 checks passed
@betsytraran betsytraran deleted the bugfix/toggle-i-fieldarray branch December 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants