Refaktorert Kommuner2024 #3460
Merged
Refaktorert Kommuner2024 #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for filtering "kommune" codes based on the year 2024 has been shifted to the KodeverkConsumer class from the Kodeverk controller class. A utility function filterKommuner2024 has also been updated to work with KodeverkBetydningerResponse type instead of KodeverkDTO and KodeverkAdjustedDTO. This change improves the structure and organization of the code.
#deploy-kodeverk-service A new utility class, FilterUtility, has been added to handle the filtering logic previously handled by KommunerUtility and KodeverkConsumer. It includes methods for handling "Kommuner2024" filter and returning filtered KodeverkBetydningerResponse. This refactoring improves code structure and readability.
…loy-frontend #deploy-test-frontend Updated the 'kommunenummer' in DollySelect component to use the new 'Kommunenummer2024' from the AdresseKodeverk. This ensures the component's addressing conforms to 2024 municipality numbers while continuing to maintain functionality and adaptability.
Updated the reference to 'kommunenummer' in Foedsel and Adresser form components to use the newer 'Kommunenummer2024' from the AdresseKodeverk. This change ensures these components adhere to the updated municipality numbers for 2024.
stigus
approved these changes
Apr 10, 2024
|
|
||
| public static String hentKodeverk(String kodeverk) { | ||
|
|
||
| if (KOMMUNER2024.equals(kodeverk)) { |
There was a problem hiding this comment.
Denne kan byttes med onelineren return KOMMUNER2024.equals(kodeverk) ? KOMMUNER : kodeverk; 🤓
There was a problem hiding this comment.
Ja det kan den, og hele oneliner-en kunne ha vært lagt til i Konsumer, 😃
men hele poenget med FilterUtility var å introdusere en generisk måte å håndtere endringer og tillegg på, det ble ekstra tydelig, synes jeg, med den eksplisitte koden: her ber den om å få inn en endring til ... 😸
|
|
||
| public static KodeverkBetydningerResponse filterKodeverk(String kodeverk, KodeverkBetydningerResponse response) { | ||
|
|
||
| if (KOMMUNER2024.equals(kodeverk)) { |
There was a problem hiding this comment.
Samme her: return KOMMUNER2024.equals(kodeverk) ? KommunerUtility.filterKommuner2024(response) : response;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for filtering "kommune" codes based on the year 2024 has been shifted to the KodeverkConsumer class from the Kodeverk controller class. A utility function filterKommuner2024 has also been updated to work with KodeverkBetydningerResponse type instead of KodeverkDTO and KodeverkAdjustedDTO. This change improves the structure and organization of the code.