Endre SimuleringStub til å oppføre seg som det faktiske simuleringssystemet #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have periods with no utbetaling the real simulering will just not contain these periods. SimuleringStub now mimics this instead of adding periods with beløp 0.
hestad
reviewed
Feb 19, 2021
| detaljer = listOf( | ||
| createYtelse(it.getFraOgMed(), it.getTilOgMed(), utbetalingslinje.beløp), | ||
| createForskuddsskatt(it.getFraOgMed(), it.getTilOgMed(), utbetalingslinje.beløp) | ||
| Periode.create(utbetalingslinje.fraOgMed, utbetalingslinje.tilOgMed).tilMånedsperioder().filterMap { |
There was a problem hiding this comment.
Jeg skjønner fremdeles ikke hvordan filterMap er annerledes enn mapNotNull 😬
There was a problem hiding this comment.
Jeg var ikke klar over mapNotNull :p Endrer til å bruke den, og sletter filterMap (siden det er noe vi har laget).
hestad
reviewed
Feb 19, 2021
| createYtelse(it.getFraOgMed(), it.getTilOgMed(), utbetalingslinje.beløp), | ||
| createForskuddsskatt(it.getFraOgMed(), it.getTilOgMed(), utbetalingslinje.beløp) | ||
| Periode.create(utbetalingslinje.fraOgMed, utbetalingslinje.tilOgMed).tilMånedsperioder().filterMap { | ||
| if (utbetalingslinje.beløp > 0) { |
There was a problem hiding this comment.
Jeg tror jeg trenger litt påfyll på når dette gjelder annet enn ved stopputbetalinger?
There was a problem hiding this comment.
Fikk en gjennomgang muntlig, så du skal få slippe og skrive 20 setninger her ;)
hestad
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Når vi får perioder med nullutbetaling vil de relle simuleringene ikke inneholde disse periodene.
SimuleringStub vil nå også gjøre dette, i stedet for å legge til perioder med nullutbetaling.