Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refresh_token): rotate refresh tokens if configured to rotate #645

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat(refresh_token): rotate refresh tokens if configured to rotate #645

merged 2 commits into from
Feb 28, 2024

Conversation

tommytroen
Copy link
Collaborator

  • will return a new unique refresh token on refresh_token grant if rotateRefreshToken is true in OAuth2Config
  • potientially breaking change as the constructor params for OAuth2Config has changed

Example JSON config:

{
  "rotateRefreshToken": true,
}

Fixes #638

@tommytroen
feat(refresh_token): rotate refresh tokens if configured to rotate
680d95f 
* will return a new unique refresh token on refres_token grant if rotateRefreshToken is true
* potientially breaking change as the constructor params for OAuth2Config has changed
@tommytroen tommytroen requested a review from a team as a code owner February 26, 2024 14:05
@tommytroen tommytroen added enhancement New feature or request breaking breaking changes, i.e. non backwards compatible api changes and removed breaking breaking changes, i.e. non backwards compatible api changes labels Feb 26, 2024
@tommytroen tommytroen mentioned this pull request Feb 26, 2024
Closed
@tommytroen tommytroen merged commit fcb2017 into master Feb 28, 2024
3 checks passed
@tommytroen tommytroen deleted the feat_rotate_refreshtoken branch February 28, 2024 09:58
@petertgiles petertgiles mentioned this pull request Feb 28, 2024
Closed
2 tasks
@tronghn tronghn mentioned this pull request May 13, 2024
Closed
@mnigh mnigh mentioned this pull request Aug 15, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronghn tronghn tronghn approved these changes

@ybelMekk ybelMekk Awaiting requested review from ybelMekk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique new refresh token on refresh
2 participants
@tommytroen @tronghn