Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add id-token to password grant token response #610

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Dec 13, 2023

IDP's like Keycloak include the id-token (among others) in the token response for the password flow. Unfortunately there are older applications out there relying on this :(. Would be cool to also have a similar behavior here in mock-oauth2-server.

@jp7677 jp7677 requested a review from a team as a code owner December 13, 2023 14:12
Copy link
Contributor

@ybelMekk ybelMekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybelMekk ybelMekk merged commit 6f5598b into navikt:master Dec 20, 2023
3 checks passed
@jp7677
Copy link
Contributor Author

jp7677 commented Jan 2, 2024

Hi @ybelMekk thanks again for merging this. Any chance of a new tag/release in the near future? Having a mock-oauth2-server image in ghcr that includes this would be really cool and convenient.
Thanks!

@jp7677
Copy link
Contributor Author

jp7677 commented Jan 8, 2024

@ybelMekk gently ping.

@jp7677 jp7677 mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants