Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic client authentication for token exchange grant #564

Merged
merged 6 commits into from
Oct 17, 2023
Merged

feat: basic client authentication for token exchange grant #564

merged 6 commits into from
Oct 17, 2023

Conversation

valdemon
Copy link
Contributor

@valdemon valdemon commented Oct 9, 2023

Solves #558

@valdemon valdemon requested a review from a team as a code owner October 9, 2023 22:12
@valdemon valdemon mentioned this pull request Oct 9, 2023
Closed
@ybelMekk ybelMekk added the enhancement New feature or request label Oct 10, 2023
ybelMekk
ybelMekk approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ybelMekk ybelMekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ybelMekk
Copy link
Contributor

@valdemon , some lint errors 😄

@ybelMekk ybelMekk linked an issue Oct 10, 2023 that may be closed by this pull request
Basic Client Authentication not supported for the Token Exchange Grant #558
Closed
@valdemon
Copy link
Contributor Author

@valdemon , some lint errors 😄

yeah, the test title is too long - fixing...

@valdemon
Copy link
Contributor Author

@ybelMekk fix done

@ybelMekk
Copy link
Contributor

@tommytroen, any comments?

tommytroen
tommytroen approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@tommytroen tommytroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybelMekk ybelMekk merged commit 3019aa3 into navikt:master Oct 17, 2023
1 check passed
@valdemon valdemon deleted the 558-basic-client-authentication-for-token-exchange branch October 17, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybelMekk ybelMekk ybelMekk approved these changes

@tommytroen tommytroen tommytroen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic Client Authentication not supported for the Token Exchange Grant
3 participants
@valdemon @ybelMekk @tommytroen