Added "code_challenge_methods_supported" to well known response #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-eisenmann
force-pushed
the
master
branch
2 times, most recently
from
35dec0f to
2769b4f
Compare
|
Whoo. Nice additions. Im going to look into it later today. |
ybelMekk
approved these changes
Jul 4, 2023
ybelMekk
reviewed
Jul 4, 2023
|
@jksolbakken or @tronghn anything to add before i merge this? |
jksolbakken
approved these changes
Jul 5, 2023
|
Wait nevermind, we do support PKCE already 😄 |
|
@sascha-eisenmann your changes have been released in 0.5.10. Thanks for your contribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am currently trying to use the mock server with the Okta JavaScript SDK. The client currently throws an error because the property "code_challenge_methods_supported" is missing in the .well-known response.
If I add the property, the mock server can be used to mock Okta requests, which is really cool for local development purposes.