Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssl): support SSL/TLS from debugger client #407

Merged
merged 9 commits into from
Jan 30, 2023
Merged

fix(ssl): support SSL/TLS from debugger client #407

merged 9 commits into from
Jan 30, 2023

Conversation

tommytroen
Copy link
Collaborator

@tommytroen tommytroen commented Jan 5, 2023 •
edited
Loading

  • add server certificate to trustchain used by debugger client
  • ignore certificate_unknown exception from Netty as it doesn't seem to affect the server, and no known fixes has been found for localhost certs.
  • fix [Docker] HTTPS configuration not working #385

@tommytroen tommytroen requested a review from ybelMekk January 5, 2023 21:35
@tommytroen tommytroen requested a review from a team as a code owner January 5, 2023 21:35
@tommytroen
fix(ssl): support SSL/TLS from debugger client
a9304a1 
* ignore certificate_unknown exception from Netty as it doesn't seem to affect the server, and no known fixes has been found for localhost certs.
@tommytroen tommytroen mentioned this pull request Jan 5, 2023
Closed
@github-actions github-actions bot added the stale label Jan 23, 2023
ybelMekk
ybelMekk approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@ybelMekk ybelMekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Tommy T

@ybelMekk ybelMekk added the bug Something isn't working label Jan 23, 2023
@github-actions github-actions bot added renewed and removed stale labels Jan 24, 2023
dependabot bot added 6 commits January 30, 2023 10:23
@dependabot @tommytroen
chore(deps): bump oauth2-oidc-sdk from 10.4 to 10.5.1
599c8e2 
Bumps [oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 10.4 to 10.5.1.
- [Changelog](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/master/CHANGELOG.txt)
- [Commits](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/branches/compare/10.5.1..10.4)

---
updated-dependencies:
- dependency-name: com.nimbusds:oauth2-oidc-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tommytroen
chore(deps): bump netty-all from 4.1.86.Final to 4.1.87.Final
0a397d1 
Bumps [netty-all](https://github.com/netty/netty) from 4.1.86.Final to 4.1.87.Final.
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](netty/netty@netty-4.1.86.Final...netty-4.1.87.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-all
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tommytroen
chore(deps): bump freemarker from 2.3.31 to 2.3.32
35a28f0 
Bumps freemarker from 2.3.31 to 2.3.32.

---
updated-dependencies:
- dependency-name: org.freemarker:freemarker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tommytroen
chore(deps): bump assertj-core from 3.23.1 to 3.24.2
50fa1cb 
Bumps assertj-core from 3.23.1 to 3.24.2.

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tommytroen
chore(deps): bump jacksonVersion from 2.14.1 to 2.14.2
bc1644c 
Bumps `jacksonVersion` from 2.14.1 to 2.14.2.

Updates `jackson-databind` from 2.14.1 to 2.14.2
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `jackson-module-kotlin` from 2.14.1 to 2.14.2
- [Release notes](https://github.com/FasterXML/jackson-module-kotlin/releases)
- [Commits](FasterXML/jackson-module-kotlin@jackson-module-kotlin-2.14.1...jackson-module-kotlin-2.14.2)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.fasterxml.jackson.module:jackson-module-kotlin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tommytroen
chore(deps): bump dependabot/fetch-metadata from 1.3.5 to 1.3.6
f073e09 
Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.3.5 to 1.3.6.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v1.3.5...v1.3.6)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@tommytroen tommytroen merged commit bafe58b into master Jan 30, 2023
@tommytroen tommytroen deleted the debugger_with_ssl branch January 30, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybelMekk ybelMekk ybelMekk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working renewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docker] HTTPS configuration not working
2 participants
@tommytroen @ybelMekk