Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): bump logback/slf4j to enable logging in docker #394

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix(logging): bump logback/slf4j to enable logging in docker #394

merged 1 commit into from
Dec 15, 2022

Conversation

tommytroen
Copy link
Collaborator

@tommytroen tommytroen commented Dec 15, 2022 •
edited
Loading

  • fixes No logging in docker #388 by upgrading slf4j to 2.x (indirectly via logback)
  • spring boot tests were failing due to Spring 2.7.x requiring slf4j 1.7.x
  • added spring.factories to prevent Spring from using its LoggingSystemLogback class causing a NoClassDefFoundError on class removed from slf4j 2.x
  • add sample docker-compose.yaml to easily test standalone mode

@tommytroen
fix(logging): bump logback to get newer version than 1.7.x of slf4j
11b635a 
* fixes #388 by upgrading slf4j to 2.x
* spring boot tests were failing due to Spring 2.7.x requiring slf4j 1.7.x
* added spring.factories to prevent Spring from using its LoggingSystemLogback class causing a NoClassDefFoundError on class removed from slf4j 2.x
* add sample docker-compose.yaml to easily test standalone mode
@tommytroen tommytroen requested a review from a team as a code owner December 15, 2022 16:22
@tommytroen tommytroen added the bug Something isn't working label Dec 15, 2022
@tommytroen tommytroen changed the title fix(logging): bump logback to get 2.x version of slf4j rather than 1.7.x fix(logging): bump logback/slf4j to enable logging in docker Dec 15, 2022
@tommytroen tommytroen mentioned this pull request Dec 15, 2022
Closed
@tommytroen
Copy link
Collaborator Author

@ybelMekk this should solve the logging issue and the spring boot dependency hell.. I'll go ahead and merge this one.

@tommytroen tommytroen merged commit 9008db9 into master Dec 15, 2022
@tommytroen tommytroen deleted the slf4j_logging branch December 15, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No logging in docker
1 participant
@tommytroen