refactor(oauth2httprequest): simplify logic for proxy aware url #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tommytroen
commented
Dec 15, 2022
tommytroen
commented
- the existing implementation logic was a bit hard to follow, hopefully this PR makes it more readable
tommytroen
force-pushed
the
simplify_proxy_aware_url
branch
from
d1c70a3 to
6a6605c
Compare
jp7677
pushed a commit
to jp7677/mock-oauth2-server
that referenced
this pull request
Dec 13, 2023
…upport iss != sub (iss navikt#393). also a workaround introduced in kotest. read more her: https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/49393129902c455bd58ae73355d2598d919c1f2f/CHANGELOG.txt#lines-2071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.