fix(jwt): provide algorithm when verifying signature and issuer #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thank you for opening this PR. Seems like Im the guilty one for this 🐛 Looking forward too.. 👀 |
antoineauger
force-pushed
the
fix/missing-algorithm
branch
from
40dc72b to
f6d2c49
Compare
antoineauger
force-pushed
the
fix/missing-algorithm
branch
from
f6d2c49 to
92f4952
Compare
|
This is ready for review 🙏🏻 I also fixed some minor typos, reformat files and clean some unused imports 😉 /cc @ybelMekk |
ybelMekk
requested changes
Oct 14, 2022
src/test/kotlin/no/nav/security/mock/oauth2/introspect/IntrospectTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/no/nav/security/mock/oauth2/introspect/IntrospectTest.kt
Outdated
Show resolved
Hide resolved
@ybelMekk I removed the unwanted Thanks for the review 🏓 |
|
@tommytroen you have the last say 😄 |
|
LGTM 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered this project yesterday and setup/used it with success today.
This is the perfect fit for one of our internal project, so a huge thanks 🙏🏻
This MR fixes the errors returned by some endpoints when using a non-default
algorithm, for instanceRS384:{ "tokenProvider" : { "keyProvider" : { "algorithm" : "RS384" } } }Before this MR, if the token generated with algorithms was different than
RS256, the following error was returned by the/userinfoand/introspectendpoints :{ "error_description": "signed jwt rejected: another algorithm expected, or no matching key(s) found", "error": "invalid_token" }🛠️ with ❤️ by Siemens