-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oppdatert ktlint til 0.48.2 #1990
Conversation
) | ||
beskrivelse = "Førstegangsbehandling - manuelt opprettet", | ||
), | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Den siste her skjønner jeg ikke helt hvorfor den skal være her.
Vi kan ju også skru av trailing comma.
): List<BehandlingBarn> { | ||
feilHvis( | ||
ustrukturertDokumentasjonType != UstrukturertDokumentasjonType.PAPIRSØKNAD && | ||
barnSomSkalFødes.isNotEmpty() | ||
barnSomSkalFødes.isNotEmpty(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette blir ju også koko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enig, dette kan vel ikke være meningen fra ktlint sin side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tolker det som at det er "ønskelig" for multiline-argument 👀 Gir vel kanskje litt mening, men ser stygt ut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skjønner. Ja, selv om det er best å ha mest mulig default, så ser regelen ut til å være en god kandidat til å ignorere
f859307
to
89b8c3c
Compare
) | ||
|
||
enum class AuditLoggerEvent(val type: String) { | ||
CREATE("create"), | ||
UPDATE("update"), | ||
DELETE("delete"), | ||
ACCESS("access") | ||
ACCESS("access"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fram, tilbake, fram tilbake ... 😂
89b8c3c
to
3586f5e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
3586f5e
to
3d9bec5
Compare
3d9bec5
to
0c9e497
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Noen issues som blitt ignorert i
.editorconfig
no-semi
rule removes semicolons in enum, even if continues companion object pinterest/ktlint#1733