Search: i18n + remove role #3280
Open
+49
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b6b740 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HalvorHaugan
commented
Oct 24, 2024
| /* | ||
| * Exposes role attribute. | ||
| */ | ||
| role?: string; |
There was a problem hiding this comment.
SearchProps extends InputHTMLAttributes which already includes role
Storybook demo43e28384a | 91 komponenter | 144 stories |
HalvorHaugan
commented
Oct 24, 2024
|
|
||
| const handleClear = useCallback( |
There was a problem hiding this comment.
useCallback had no effect since only these two functions had it.
HalvorHaugan
commented
Oct 25, 2024
Comment on lines
+40
to
+45
| Search: { | ||
| clear: "Tøm", | ||
| Button: { | ||
| search: "Søk", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
We could discuss if it's necessary to have search in a nested object 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")