-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sorting lists by name/title case-insensitive #2993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Download the artifacts for this pull request: |
3 tasks
felipemarinho97
added a commit
to felipemarinho97/navidrome
that referenced
this pull request
Aug 7, 2024
* Bump golang.org/x/sync from 0.6.0 to 0.7.0 Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.6.0 to 0.7.0. - [Commits](golang/sync@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.31.1 to 1.32.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.31.1...v1.32.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix DiscTitle OpenSubsonic compatibility. Closes navidrome#2929 * Bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.1 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.15.0 to 2.17.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.15.0...v2.17.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github.com/pressly/goose/v3 from 3.18.0 to 3.19.2 Bumps [github.com/pressly/goose/v3](https://github.com/pressly/goose) from 3.18.0 to 3.19.2. - [Release notes](https://github.com/pressly/goose/releases) - [Changelog](https://github.com/pressly/goose/blob/master/CHANGELOG.md) - [Commits](pressly/goose@v3.18.0...v3.19.2) --- updated-dependencies: - dependency-name: github.com/pressly/goose/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update Go to 1.22.2 and TagLib to 2.0.1 (navidrome#2946) * Bump github.com/pelletier/go-toml/v2 from 2.1.1 to 2.2.0 Bumps [github.com/pelletier/go-toml/v2](https://github.com/pelletier/go-toml) from 2.1.1 to 2.2.0. - [Release notes](https://github.com/pelletier/go-toml/releases) - [Changelog](https://github.com/pelletier/go-toml/blob/v2/.goreleaser.yaml) - [Commits](pelletier/go-toml@v2.1.1...v2.2.0) --- updated-dependencies: - dependency-name: github.com/pelletier/go-toml/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github.com/go-chi/jwtauth/v5 from 5.3.0 to 5.3.1 Bumps [github.com/go-chi/jwtauth/v5](https://github.com/go-chi/jwtauth) from 5.3.0 to 5.3.1. - [Release notes](https://github.com/go-chi/jwtauth/releases) - [Commits](go-chi/jwtauth@v5.3.0...v5.3.1) --- updated-dependencies: - dependency-name: github.com/go-chi/jwtauth/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix function name in comment (navidrome#2947) Signed-off-by: looklose <[email protected]> * Fix a few mistakes in the French translation (navidrome#2872) Co-authored-by: Deluan Quintão <[email protected]> * Ignore formatting diffs when checking for POEditor changes * Fix some typos in comments (navidrome#2949) Signed-off-by: oftenoccur <[email protected]> * Add make target to build docker image * Bump follow-redirects from 1.15.4 to 1.15.6 in /ui (navidrome#2911) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /ui (navidrome#2845) Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.2.0 to 6.4.2. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.2.0...v6.4.2) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 3.2.2 to 3.2.5 in /ui (navidrome#2844) Bumps [prettier](https://github.com/prettier/prettier) from 3.2.2 to 3.2.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.2.2...3.2.5) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove deprecation warning about `notify` * Fix jukebox mode under Windows (navidrome#2774) * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Use named pipe for socket path under windows during mpv playback, change function name, unexport function Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Fix typo Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Early return for Close on Windows Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Update import and run prettier Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Update function name Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Create track_close files for both platforms and move MpvTrack Close into new file Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Create SocketName function for both platforms, restore name of TempFileName Signed-off-by: apkatsikas <[email protected]> * bug(core/playback/mpv): jukebox mode under windows - navidrome#2767 Add missing params to SocketName on windows Signed-off-by: apkatsikas <[email protected]> * Unexport SocketName, use socketName in NewTrack --------- Signed-off-by: apkatsikas <[email protected]> * Bump github.com/pelletier/go-toml/v2 from 2.2.0 to 2.2.1 (navidrome#2956) Bumps [github.com/pelletier/go-toml/v2](https://github.com/pelletier/go-toml) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/pelletier/go-toml/releases) - [Changelog](https://github.com/pelletier/go-toml/blob/v2/.goreleaser.yaml) - [Commits](pelletier/go-toml@v2.2.0...v2.2.1) --- updated-dependencies: - dependency-name: github.com/pelletier/go-toml/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-icons from 5.0.1 to 5.1.0 in /ui (navidrome#2957) Bumps [react-icons](https://github.com/react-icons/react-icons) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/react-icons/react-icons/releases) - [Commits](react-icons/react-icons@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: react-icons dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Externalize MPV command template (navidrome#2948) * externalise MPVTemplate * Remove unnecessary comment --------- Co-authored-by: Deluan <[email protected]> * Bump golang.org/x/net from 0.21.0 to 0.23.0 (navidrome#2962) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.23.0. - [Commits](golang/net@v0.21.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix issue in navidrome#2767 (comment) * Block regular users from changing their own playlists ownership * Allow comments in the NSP file. See comment navidrome#1417 (comment) * Fix typo * Include MPV in release Docker image. Refers to navidrome#2910 * Bump github.com/onsi/gomega from 1.32.0 to 1.33.0 (navidrome#2968) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.32.0 to 1.33.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.32.0...v1.33.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Handling long playlist comments (navidrome#2973) Closes navidrome#1737 * wrapping playlist comment in a <Collapse> element * Extract common collapsible logic into a component --------- Co-authored-by: Deluan <[email protected]> * Use the RealIP middleware also behind a reverse proxy (navidrome#2858) * Use the RealIP middleware only behind a reverse proxy * Fix proxy ip source in tests * Fix test for PR#2087 The PR did not update the test after changing the behavior, but the test still passed because another condition was preventing the user from being created in the test. * Use RealIP even without a trusted reverse proxy * Use own type for context key * Fix casing to follow go's conventions * Do not apply RealIP middleware twice * Fix IP source in logs The most interesting data point in the log message is the proxy's IP, but having the client IP too can help identify integration issues. * Fix scrobble error spam in the logs. Relates to navidrome#2831 and navidrome#2975 * Add OpenSubsonic channelCount * Fix typo in comment (navidrome#2974) * Bump github.com/pressly/goose/v3 from 3.19.2 to 3.20.0 * Bump Go dependencies (navidrome#2976) * Fix build * Bump dependencies * Bump github.com/spf13/viper from 1.15.0 to 1.18.2 * Add support for Reverse Proxy auth in Subsonic endpoints (navidrome#2558) * feat(subsonic): Add support for Reverse Proxy auth - navidrome#2557 Signed-off-by: Jeremiah Menétrey <[email protected]> * Small refactoring --------- Signed-off-by: Jeremiah Menétrey <[email protected]> Co-authored-by: Deluan Quintão <[email protected]> * Add AlbumPlayCountMode config option (navidrome#2803) Closes navidrome#1032 * feat(album_repository.go): add kodi-style album playcount option - navidrome#1032 Signed-off-by: Victor van der Veen <[email protected]> * fix format issue and remove reference to kodi (now normalized) Signed-off-by: Victor van der Veen <[email protected]> * reduced complexity but added rounding Signed-off-by: Victor van der Veen <[email protected]> * Use constants for AlbumPlayCountMode values --------- Signed-off-by: Victor van der Veen <[email protected]> Co-authored-by: Deluan <[email protected]> * Add tests for AlbumPlayCountMode * Add tests for AlbumPlayCountMode, change the calc to match the request from navidrome#1032 * Remove AlbumPlayCountMode from command line options * Load mime_types from external file * Refactor DB Album mapping to model.Album * Refactor loadGenres, remove duplication * Use signal.NotifyContext * Fix signaler on Windows * Fix int types in OpenSubsonic responses. Refer to https://support.symfonium.app/t/symfonium-sync-crashes-when-tpos-is-not-an-int/4204 * Fix AlbumPlayCountMode. Closes navidrome#2984 * Fix PlaylistTracks's loadAllGenres. Fix navidrome#2988 * Bump Go dependencies * Sort repeated lyrics that may be out of order (navidrome#2989) With synchronized lyrics with repeated text, there is not a guarantee that the repeat is in order (e.g. `[00:00.00][00:10.00] a\n[00:05.00]b`). This change will post-process lyrics with repeated timestamps in one line to ensure that it is always sorted. * Fix typo * Add `HTTPSecurityHeaders.CustomFrameOptionsValue` option. Requested in navidrome#248 (comment) * Fix CollapsibleComment in PlaylistDetails. Closes navidrome#2992 * Pin golangci-lint-action version as a workaround to fix the pipeline. See golangci/golangci-lint#4695 * Improves golangci-lint configuration and workflow (navidrome#3004) * chore: the default Go version is based on the go.mod * chore: use linter configuration instead of exclude-rules * chore: update workflow * Persist adjusted volume (navidrome#2997) Co-authored-by: Deluan Quintão <[email protected]> * Guard against missing active track (navidrome#2996) Co-authored-by: Deluan Quintão <[email protected]> * Bump Go dependencies * Limit access to Jukebox for admins only (configurable). Closes navidrome#2849 * Fix ambiguous column when sorting media_files by created_at. Fix navidrome#3006 * Change default transcodings to a proper typed struct * Fix migration package name mismatch * Make dependency injection more consistent * Terminate all MPV instances when stopping Navidrome (navidrome#3008) * Terminate all mpv instances when stopping Navidrome * Exit trackSwitcher goroutine when terminating * Remove potential race condition when starting the Playback device * Fix lint error * Removed unused and unneeded vars/functions * Use device short name in log * Small refactor * Small nitpick * Make start functions more uniform * Make sorting lists by name/title case-insensitive (navidrome#2993) * Make sort by order_* fields case-insensitive. * Sort internet radios by name case-insensitive * Clean up runNavidrome function * Remove unused code * Simplify normalized AlbumPlayCountMode calc * fix: languageName for Persian (navidrome#3011) "انگلیسی" is "English" * Update Go to 1.22.3 * Fix M3U mimetype on Debian Bullseye * Replace sync.WaitGroup with more appropriate errgroup.Group * Bump actions/stale and dessant/lock-threads versions * Bump actions/github-script to v7 * Add Catppuccin Macchiato Theme (navidrome#3014) * Added Catppuccin Macchiato theme * fixed index.js formatting * Do not panic if when updatePlaylist is called with a non-existent ID. Fix navidrome#2876 * Read sampleRate from audio files * Add sampleRate to the DB * Add samplingRate to OpenSubsonic responses * Fix "Add download link to PR" workflow * Refactor merge.FS * Refactor cache.HTTPClient * Uses Unix milliseconds support from standard Go lib * Refactor random functions * Simplify random.Int64 usage with generics * Remove duplicated test * Revert "Add download link to PR" workflow * Change dsf mime-type to audio/x-dsf. Fix navidrome#3021 * Update Go to 1.22.3 * Refactor to use more Go 1.22 features * Rename MediaFolder to Library * Store MusicFolder as a library in DB * Associate main entities with library * Fix race condition * fix bug in jukebox: property unavailable (navidrome#3024) * fix bug in jukebox: property unavailable * fix lint error * Fix memory leak in CachedGenreRepository (navidrome#3031) that the scanner was run, the ttlcache was also created each time. This caused (under testing with 166 genres in the database) the memory consumed by navidrome to 101.18MB over approx 3 days; 96% of which is in instances of this cache. Swapping to a singleton has reduced this to down to ~ 2.6MB Co-authored-by: Rob Emery <[email protected]> * Improve resizeImage code readability * Simplify image format detection code * Simplify resources.FS * Refactor random.WeightedChooser, unsing generics * Fix lint error * Always run docker steps (navidrome#3034) * Fix docker publishing for PRs * Revert "Fix docker publishing for PRs" This reverts commit 15c9a0d. * Revert "Always run docker steps (navidrome#3034)" This reverts commit 5d41165. * Deterministic pagination in random albums sort (navidrome#1841) * Deterministic pagination in random albums sort * Reseed on first random page * Add unit tests * Use rand in Subsonic API * Use different seeds per user on SEEDEDRAND() SQLite3 function * Small refactor * Fix id mismatch * Add seeded random to media_file (subsonic endpoint `getRandomSongs`) * Refactor * Remove unneeded import --------- Co-authored-by: Deluan <[email protected]> * Add missing Test function * Make first WebUI random page stick * Update caniuse-lite * Fix 32 bits builds * Fix G404 gosec lint error * Update Ukrainian translations (navidrome#3029) Co-authored-by: deluan <[email protected]> * Show number of results from a query in the logs * Bump github.com/matoous/go-nanoid/v2 from 2.0.0 to 2.1.0 (navidrome#3038) Bumps [github.com/matoous/go-nanoid/v2](https://github.com/matoous/go-nanoid) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/matoous/go-nanoid/releases) - [Commits](matoous/go-nanoid@v2.0.0...v2.1.0) --- updated-dependencies: - dependency-name: github.com/matoous/go-nanoid/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Optimize SQLite3 access. Mainly separate read access from write access. Based on tips from https://archive.is/Xfjh6#selection-257.0-278.0 * Replace panics with log.Fatals * Fix XML marshaling of OpenSubsonic structured lyrics (navidrome#3041) * Revert isDBInitialized * Fix image stuttering (navidrome#3035) * Fix image stuttering. * Fix docker publishing for PRs * Write tests for new square parameter. * Simplify code for createImage. --------- Co-authored-by: Deluan Quintão <[email protected]> * Small optimization in MediaFiles.ToAlbum() * Bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0 (navidrome#3054) Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.3 to 2.19.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.17.3...v2.19.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Simplify dbx wrapper * Bump github.com/spf13/viper from 1.18.2 to 1.19.0 (navidrome#3068) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.2 to 1.19.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.18.2...v1.19.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 3.2.5 to 3.3.0 in /ui (navidrome#3069) Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.2.5...3.3.0) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix tests expectations * Refactor string utilities into its own package `str` * Small refactoring * Replace gg.If with cmp.Or * Initialize Index Groups regex just once * More micro-optimizations * Small refactoring * Fix race condition in external metadata retrieval * Increase artist image url sizes. See https://support.symfonium.app/t/artist-picture-less-compressed/4447 * Change resized image cache key * Add R128_{TRACK,ALBUM}_GAIN support to the scanner (navidrome#3072) * Add R128 gain tags support to the scanner * Add R128 test to metadata_internal_test.go * Pass explicit tag names to getGainValue function * Don't expose `fullText` data in the Native API * Bump prettier from 3.3.0 to 3.3.1 in /ui Bumps [prettier](https://github.com/prettier/prettier) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.0...3.3.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Do not use lastFM api key and secret to determine if LastFM.Enabled should be set. * Increase artist image url sizes. See https://support.symfonium.app/t/artist-picture-less-compressed/4447 * Bump uuid from 9.0.1 to 10.0.0 in /ui Bumps [uuid](https://github.com/uuidjs/uuid) from 9.0.1 to 10.0.0. - [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md) - [Commits](uuidjs/uuid@v9.0.1...v10.0.0) --- updated-dependencies: - dependency-name: uuid dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump react-icons from 5.1.0 to 5.2.1 in /ui Bumps [react-icons](https://github.com/react-icons/react-icons) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/react-icons/react-icons/releases) - [Commits](react-icons/react-icons@v5.1.0...v5.2.1) --- updated-dependencies: - dependency-name: react-icons dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump golang.org/x/image from 0.16.0 to 0.17.0 Bumps [golang.org/x/image](https://github.com/golang/image) from 0.16.0 to 0.17.0. - [Commits](golang/image@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump clsx from 2.1.0 to 2.1.1 in /ui Bumps [clsx](https://github.com/lukeed/clsx) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/lukeed/clsx/releases) - [Commits](lukeed/clsx@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: clsx dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump ejs from 3.1.9 to 3.1.10 in /ui Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Bump @testing-library/jest-dom from 6.4.2 to 6.4.5 in /ui Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.4.2 to 6.4.5. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.4.2...v6.4.5) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.0 to 1.19.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.19.0...v1.19.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix album/media file random sort (navidrome#3089) * Add http headers to trace log * Wrap ttlcache in our own SimpleCache implementation * Also use SimpleCache in cache.HTTPClient * Upgrade to ttlcache/v3 * Evict expired items from SimpleCache * Don't panic on PostScan errors. Fix navidrome#3118 * Bump golang.org/x/image from 0.17.0 to 0.18.0 (navidrome#3119) Bumps [golang.org/x/image](https://github.com/golang/image) from 0.17.0 to 0.18.0. - [Commits](golang/image@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/lestrrat-go/jwx/v2 from 2.0.21 to 2.1.0 (navidrome#3113) Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.0.21 to 2.1.0. - [Release notes](https://github.com/lestrrat-go/jwx/releases) - [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes) - [Commits](lestrrat-go/jwx@v2.0.21...v2.1.0) --- updated-dependencies: - dependency-name: github.com/lestrrat-go/jwx/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/go-chi/chi/v5 from 5.0.12 to 5.0.14 (navidrome#3115) Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.0.12 to 5.0.14. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.0.12...v5.0.14) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/pressly/goose/v3 from 3.20.0 to 3.21.1 (navidrome#3114) Bumps [github.com/pressly/goose/v3](https://github.com/pressly/goose) from 3.20.0 to 3.21.1. - [Release notes](https://github.com/pressly/goose/releases) - [Changelog](https://github.com/pressly/goose/blob/master/CHANGELOG.md) - [Commits](pressly/goose@v3.20.0...v3.21.1) --- updated-dependencies: - dependency-name: github.com/pressly/goose/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 3.3.1 to 3.3.2 in /ui (navidrome#3097) Bumps [prettier](https://github.com/prettier/prettier) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.1...3.3.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @testing-library/jest-dom from 6.4.5 to 6.4.6 in /ui (navidrome#3096) Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.4.5 to 6.4.6. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.4.5...v6.4.6) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump braces from 3.0.2 to 3.0.3 in /ui (navidrome#3085) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (navidrome#3095) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove unnecessary annotation table primary key * Add Nuclear Theme (navidrome#3098) * fix background color for nord theme (navidrome#3124) * Bump github.com/go-chi/chi/v5 from 5.0.14 to 5.1.0 (navidrome#3126) Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.0.14 to 5.1.0. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.0.14...v5.1.0) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/unrolled/secure from 1.14.0 to 1.15.0 (navidrome#3127) Bumps [github.com/unrolled/secure](https://github.com/unrolled/secure) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/unrolled/secure/releases) - [Commits](unrolled/secure@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/unrolled/secure dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix album sorting in Artist page * Remove unnecessary Fragment component. * Add Auto-Import toggle switch to playlists list view. * Fix race condition * Bump github.com/go-chi/httprate from 0.9.0 to 0.10.0 (navidrome#3160) Bumps [github.com/go-chi/httprate](https://github.com/go-chi/httprate) from 0.9.0 to 0.10.0. - [Commits](go-chi/httprate@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: github.com/go-chi/httprate dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Hungarian language (navidrome#3157) * Use SHA256 in Gravatar URLs * Fix "Cannot read properties of undefined". Closes navidrome#3070 * Bump github.com/microcosm-cc/bluemonday from 1.0.26 to 1.0.27 (navidrome#3141) Bumps [github.com/microcosm-cc/bluemonday](https://github.com/microcosm-cc/bluemonday) from 1.0.26 to 1.0.27. - [Release notes](https://github.com/microcosm-cc/bluemonday/releases) - [Commits](microcosm-cc/bluemonday@v1.0.26...v1.0.27) --- updated-dependencies: - dependency-name: github.com/microcosm-cc/bluemonday dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/onsi/gomega from 1.33.1 to 1.34.0 (navidrome#3176) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.1 to 1.34.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.33.1...v1.34.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Use userId in player, other fixes (navidrome#3182) * [bugfix] player: use userId, other fixes This PR primarily resolves navidrome#1928 by switching the foreign key of `player` from `user.user_name` to `user.id`. There are also a few other fixes/changes: - For some bizarre reason, `ip_address` is never returned from `read`/`get`. Change the field to `ip`, which works. Somehow - Update `players_test.go` mock to also check for user agent, replicating the actual code - Update `player_repository.go` `isPermitted` to check user id. I don't know how this worked before... - tests! - a few places referred to `typ`, when it is really `userAgent`. Change the field names * baseRequest -> selectPlayer * remove comment * update migration, make all of persistence foreign key enabled * maybe don't forget to save the file first * Use same key for replaygain's preAmp (navidrome#3184) Resolves navidrome#2933. To prevent this from happening again, make the localstorage keys consts for set/get * Fix Player filter --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: looklose <[email protected]> Signed-off-by: oftenoccur <[email protected]> Signed-off-by: apkatsikas <[email protected]> Signed-off-by: Jeremiah Menétrey <[email protected]> Signed-off-by: Victor van der Veen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deluan <[email protected]> Co-authored-by: looklose <[email protected]> Co-authored-by: Cyrille <[email protected]> Co-authored-by: oftenoccur <[email protected]> Co-authored-by: Andrew Katsikas <[email protected]> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Tim <[email protected]> Co-authored-by: crazygolem <[email protected]> Co-authored-by: Anna Smith <[email protected]> Co-authored-by: vvdveen <[email protected]> Co-authored-by: Kendall Garner <[email protected]> Co-authored-by: Ludovic Fernandez <[email protected]> Co-authored-by: Matthias Schmidt <[email protected]> Co-authored-by: Valeri Sokolov <[email protected]> Co-authored-by: edthu <[email protected]> Co-authored-by: Fynn Petersen-Frey <[email protected]> Co-authored-by: Rob Emery <[email protected]> Co-authored-by: Rob Emery <[email protected]> Co-authored-by: Guilherme Souza <[email protected]> Co-authored-by: deluan <[email protected]> Co-authored-by: Drew Weymouth <[email protected]> Co-authored-by: Caio Cotts <[email protected]> Co-authored-by: kartikynwa <[email protected]> Co-authored-by: gruneforth <[email protected]> Co-authored-by: Caio Cotts <[email protected]> Co-authored-by: Soderes <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2425