INTERNAL: Remove reverse arg in bopGet and bopExtendedGet #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
force-pushed
the
internal/btreeGet
branch
from
0fa50c6 to
1296d7b
Compare
oliviarla
previously approved these changes
Jan 3, 2025
jhpark816
reviewed
Jan 3, 2025
| @@ -26,6 +26,7 @@ public class BTreeGet extends CollectionGet { | |||
| protected int offset = -1; | |||
| protected int count = -1; | |||
| protected ElementFlagFilter elementFlagFilter; | |||
| private boolean reverse; | |||
There was a problem hiding this comment.
offset, count 필드처럼 reverse 필드는 false로 초기화
| @@ -36,6 +37,7 @@ private BTreeGet(String range, | |||
| this.elementFlagFilter = elementFlagFilter; | |||
| this.eHeadCount = 2; | |||
| this.eFlagIndex = 1; | |||
| this.reverse = false; | |||
There was a problem hiding this comment.
앞에서 초기화하였으므로, 이 코드는 없어도 됨
| @@ -52,24 +54,30 @@ public BTreeGet(byte[] bkey, | |||
|
|
|||
| private BTreeGet(String range, int offset, int count, | |||
| boolean delete, boolean dropIfEmpty, | |||
| ElementFlagFilter elementFlagFilter) { | |||
| ElementFlagFilter elementFlagFilter, boolean reverse) { | |||
There was a problem hiding this comment.
range, reverse, offset, count, .... 순서이면 좋겠습니다.
from, to 값을 <String 타입의 range 값, boolean 타입의 reverse 값> 으로 변환하여 보관한다고 보면 될 것 같습니다.
brido4125
force-pushed
the
internal/btreeGet
branch
from
43fc516 to
09347eb
Compare
jhpark816
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
https://github.com/jam2in/arcus-works/issues/656
⌨️ What I did
private 접근 제어인 asyncBopGet, asyncBopExtendedGet의
reverse 인자를 제거하고
이를 BopGet 인스턴스의 isReverse로 대체한다.