WMDP-195: Automatically run linting/formatting/tests in CI for PRs and merges to main #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
changed the title
rocketnova
approved these changes
Sep 20, 2022
We could potentially if we set that up, but it'll require a bit of tinkering with the makefile commands I think. Should we make that as a follow-up? docker/build-push-action#225 has the details on how to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - testing github actions
Ticket
https://wicmtdp.atlassian.net/browse/WMDP-195
Changes
Updated the api-checks file to run linting/formatting/tests when creating PRs and when merges to main happen.
Added bandit which looks for any security vulnerabilities present in your code.
Testing
Most of the testing can be seen here in the actions that ran against this PR.
Successful run: https://github.com/navapbc/wic-mt-demo-project-mock-api/actions/runs/3069343936
Run where I made a multi-head migration issue deliberately: https://github.com/navapbc/wic-mt-demo-project-mock-api/actions/runs/3069316636
Formatting issue: https://github.com/navapbc/wic-mt-demo-project-mock-api/actions/runs/3069295227