Replace black, flake8, pydocstyle, bandit with ruff #314
Conversation
jdrew82
requested review from
alhogan,
a team,
qduk and
chadell
as code owners
…ings to pyproject.toml. Also addressed all the complaints that were raised.
…project.toml now.
|
FYI: bandit in ruff is still missing 3 checks, 2 of which are django ones, additionally a bunch have been added recently, so not sure if they have been released. |
| @@ -41,6 +41,8 @@ def _move_data(apps, schema_editor): | |||
|
|
|||
|
|
|||
| class Migration(migrations.Migration): | |||
| """Migration class.""" | |||
There was a problem hiding this comment.
These should not be needed, we should update the configuration for pydocstyle's ruff equivalant to not need doc strings.
Any chance you have a link with details about this? |
astral-sh/ruff#1646 and the faq has been very helpful in knowing what is ready vs not as well as the links. |
|
Thanks. It's not clear to me how the "missing" |
|
I don't know, tbh, here are the relevant links https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b308-mark-safe vs https://bandit.readthedocs.io/en/latest/plugins/b703_django_mark_safe.html |
|
Closing for now until we figure out how we want to proceed with ruff. |
This PR is to update the project linters to replace black, flake8, pydocstyle, and bandit with ruff. This speeds up tests significantly.