Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Align with template #80

Merged
merged 3 commits into from
Mar 29, 2023
Merged

chore: Align with template #80

merged 3 commits into from
Mar 29, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Mar 20, 2023

Fixes: #79

Done

  • Added CI upstream testing
  • Bumped Nautobot minimal version to 1.4
  • Aligned with the template:
    • Project configuration files
    • Tooling configuration files
    • Development compose and invoke files
    • CI workflow

@snaselj snaselj marked this pull request as ready for review March 20, 2023 08:18
@snaselj snaselj requested a review from jeffkala as a code owner March 20, 2023 08:18
@snaselj
Copy link
Contributor Author

snaselj commented Mar 20, 2023

This PR is ready for review now

@itdependsnetworks
Copy link
Contributor

Looks good!! Thanks for this.

Just to confirm, have you invoke build and tested that the docs and the instance come up without issues?

@snaselj snaselj marked this pull request as draft March 20, 2023 16:24
@snaselj snaselj marked this pull request as ready for review March 20, 2023 16:47
@snaselj
Copy link
Contributor Author

snaselj commented Mar 20, 2023

Looks good!! Thanks for this.

Just to confirm, have you invoke build and tested that the docs and the instance come up without issues?

I added mkdocs back to tasks.py and ci.yml, it is missing in the template.

Tested both inv docs and inv start, endpoints works well.

@itdependsnetworks itdependsnetworks merged commit 0dca915 into develop Mar 29, 2023
@itdependsnetworks itdependsnetworks deleted the u/snaselj-79-align-with-template branch August 27, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkala jeffkala Awaiting requested review from jeffkala jeffkala is a code owner

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI testing (including Upstream Testing)
2 participants
@snaselj @itdependsnetworks