Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match versions #92

Merged
merged 2 commits into from
Jan 11, 2024
Merged

match versions #92

merged 2 commits into from
Jan 11, 2024

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Jan 8, 2024

No description provided.

@abates
Copy link
Contributor

abates commented Jan 8, 2024

Please provide a failing unit test that this PR fixes.

@whitej6
Copy link
Contributor Author

whitej6 commented Jan 8, 2024

Please provide a failing unit test that this PR fixes.

Due to how CI is built & run the version dependency testing is reliant on CI testing the min and max versions. Also Nautobot core validates the min/max versioning validation works as expected here

@whitej6
Copy link
Contributor Author

whitej6 commented Jan 8, 2024

Just realized I did ^1.6.0 when the app config is >=1.6.0,<=2.9999, pushed a new commit to correct this.

@abates abates merged commit b47028c into develop Jan 11, 2024
15 checks passed
@abates abates deleted the u/whitej6-update-versions branch January 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants