Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Change status from Design to Design Instance #84

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

chadell
Copy link
Contributor

@chadell chadell commented Dec 11, 2023

  • Remove Status from Design
  • Add Status to Design Instance
  • Add Live State
  • Allow delete of a Design Instance (under certain conditions)
  • Add a button to trigger a Design execution
  • Add a Tag for each object created by Design Builder

Screenshoots

image image image image

Remove Status from Design, Add Status to Design Instance, and also Live State.  Allow delete of a Design Instance (under certain conditions), and add a button to trigger a Design execution
chadell and others added 4 commits December 11, 2023 11:00
There was a cyclic import in util.py for nautobot_design_builder. There
was actually no need for this import at all so it was removed.

Also removed the try/except block for `importlib.metadata` since
design_builder now only supports Python >= 3.8 and `metadata` was added
in 3.8
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

nautobot_design_builder/models.py Outdated Show resolved Hide resolved
nautobot_design_builder/signals.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chadell chadell merged commit 3837819 into feature_delices Dec 12, 2023
14 checks passed
@chadell chadell deleted the feature_delices_status_update branch December 12, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants