Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add journaling to Design Builder #69

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

abates
Copy link
Contributor

@abates abates commented Aug 17, 2023

Added initial journaling of changes logged to the database.

@abates abates requested a review from mzbroch as a code owner August 17, 2023 19:47
@mzbroch
Copy link

mzbroch commented Aug 18, 2023

Does this replace #59 ?

@abates abates changed the base branch from develop to feature_delices August 18, 2023 11:35
@abates
Copy link
Contributor Author

abates commented Aug 18, 2023

Does this replace #59 ?

No, this adds to #59. I changed the merge base to feature-delices



# TODO: Refactor this code into the Journal model
class Journal:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a potential name collision (GraphQL)
Can we use anything like DB_Journal ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched through the nautobot core codebase for the word journal and didn't find anything except one reference to systemd's journalctl. Where do you think there may be a name collision? I'm not a fan of prefixing model names like what you proposed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying it could be popular - as it is a potential name collision, at least we should get informal confirmation from Nautobot Core about this plan to let know that we will use it inside a plugin.

@nkallergis nkallergis force-pushed the feature_delices_journal branch from dab46d3 to 408fd99 Compare September 12, 2023 16:56
@abates abates merged commit d7e02e2 into feature_delices Oct 5, 2023
7 of 8 checks passed
@whitej6 whitej6 deleted the feature_delices_journal branch December 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants