-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add journaling to Design Builder #69
Conversation
Does this replace #59 ? |
No, this adds to #59. I changed the merge base to feature-delices |
design_builder/design.py
Outdated
|
||
|
||
# TODO: Refactor this code into the Journal model | ||
class Journal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a potential name collision (GraphQL)
Can we use anything like DB_Journal ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched through the nautobot core codebase for the word journal
and didn't find anything except one reference to systemd's journalctl
. Where do you think there may be a name collision? I'm not a fan of prefixing model names like what you proposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saying it could be popular - as it is a potential name collision, at least we should get informal confirmation from Nautobot Core about this plan to let know that we will use it inside a plugin.
dab46d3
to
408fd99
Compare
Added initial journaling of changes logged to the database.