[ltm-1.6] Import mode for existing data (Leo) #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
commented
Jul 29, 2024
docs/user/design_lifecycle.md
Outdated
|
|
||
| The import logic works like this: | ||
|
|
||
| 1. If the object that we reference doesn't exist, normal design creation logic applies. |
There was a problem hiding this comment.
This needs to be updated still
Kircheneer
commented
Jul 29, 2024
Kircheneer
force-pushed
the
1.6_import_state_leo
branch
2 times, most recently
from
64ea031 to
1448892
Compare
Kircheneer
force-pushed
the
1.6_import_state_leo
branch
2 times, most recently
from
1157b02 to
2ff28a4
Compare
abates
reviewed
Jul 30, 2024
abates
reviewed
Jul 30, 2024
nautobot_design_builder/models.py
Outdated
Comment on lines
400
to
405
| # When we don't want to assume full control, make sure we don't try to own any of the query filter values. | ||
| if not entry_parameters["full_control"]: | ||
| for attribute in model_instance.metadata.query_filter_values: | ||
| entry_parameters["changes"].pop(attribute, None) |
There was a problem hiding this comment.
I don't understand what is happening here, can the code comment be clarified, please?
abates
reviewed
Jul 30, 2024
nautobot_design_builder/models.py
Outdated
Comment on lines
405
to
417
| # Check if any owned attributes exist that conflict with the changes for this instance. | ||
| for record in change_records_for_instance: | ||
| for attribute in record.changes: | ||
| if attribute in entry_parameters["changes"]: | ||
| raise ValueError( # pylint: disable=raise-missing-from | ||
| f"The {attribute} attribute for {instance} is already owned by Design Deployment {record.change_set.deployment}" | ||
| ) |
There was a problem hiding this comment.
Also here, I'm not sure what is happening... perhaps a concrete example in code comments?
Kircheneer
force-pushed
the
1.6_import_state_leo
branch
3 times, most recently
from
deb5c99 to
3852a6e
Compare
abates
approved these changes
Jul 31, 2024
|
LGTM |
Kircheneer
force-pushed
the
1.6_import_state_leo
branch
from
3852a6e to
5bd465a
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going off of #178, addressing most of the comments there but making some more drastic changes, like excluding
!createfrom usage with import mode.