Fix/neuprint roi connectivity #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* need to check that no connections are missing * progress on #87
* switch to tibble (a bit quicker than standard data.frame * don't keep on cbinding data.frames but just make one at the beginning
* first of all actually make it work * some speed ups by switching from grep to stringr::str_detect
* use some data from neuprint_find_neurons
* this actually tests equal with tibble or data.frame
* and complain if you do full=T, cached=T since it's not possible
* they're a little slow but still probably <10s and a good idea to cover the whole function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #87. Will probably still change some of the default behaviour re cached/full.