Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection table fix #8

Merged
merged 5 commits into from
Jan 13, 2020
Merged

Conversation

romainFr
Copy link
Collaborator

@romainFr romainFr commented Jan 8, 2020

Redesigned the neuprint_connection_table function, using the ConnectsTo object. This now allows to get connections split by ROI for all ROIs (the default) or the ROIs specified (as a single ROI or a vector of ROIs).

@jefferis
Copy link
Contributor

Thanks again @romainFr. Could you include an example that works against the public release server in the help for functions that you fix going forwards? You can condition them as

\donttest{
# my example code ...
}

Of course there should have been examples already ...

@jefferis jefferis merged commit 3e30e4b into natverse:master Jan 13, 2020
@romainFr romainFr deleted the connectionTableFix branch January 14, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants