-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : wrappers for path related functions #17
Conversation
… through the actual common connections
Switch to neuprint_read_neuron_simple
…lFix Small fix to avoid returning results from ROIs that start with the same letters
Hi @romainFr thanks for this start. @SridharJagannathan and I will be working seriously on the repo from start of next week. To assist with development we have often found it helpful to create feature branches on the main repo (i.e. natverse/neuprintr in this case) rather than working with PRs on your own repos. The reason is that three of us can interleave commits on a feature branch here, whereas for a PR hosted in your repo, we can only merge or comment. I've sent you an invite for this repo. I think you should also add yourself as an author rather than contributor. |
Of course you can still continue to make small self-contained PRs as before. |
Common connectivity fix
# Conflicts: # R/connectivity.R
Both functions now output a data frame with columns "to", "from", "weight", "name.to", "name.from", which should be easily parsable by most network visualization tools. |
One thing that one still might want to add is the option to restrict the paths within a given ROI (or set of ROIs) |
Tests/examples should be added, but I'm going to merge as it's working/useful (and I'll start working off natverse/neuprintr branches from now on) |
To pull all paths of a certain length range or all the shortest paths between two bodies.
For now I just wrapped the queries for now, I still need to add a nice output, so it's not ready for merging.