Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : wrappers for path related functions #17

Merged
merged 12 commits into from
Jan 16, 2020
Merged

Conversation

romainFr
Copy link
Collaborator

To pull all paths of a certain length range or all the shortest paths between two bodies.

For now I just wrapped the queries for now, I still need to add a nice output, so it's not ready for merging.

@jefferis
Copy link
Contributor

Hi @romainFr thanks for this start. @SridharJagannathan and I will be working seriously on the repo from start of next week. To assist with development we have often found it helpful to create feature branches on the main repo (i.e. natverse/neuprintr in this case) rather than working with PRs on your own repos. The reason is that three of us can interleave commits on a feature branch here, whereas for a PR hosted in your repo, we can only merge or comment. I've sent you an invite for this repo. I think you should also add yourself as an author rather than contributor.

@jefferis
Copy link
Contributor

Of course you can still continue to make small self-contained PRs as before.

@romainFr
Copy link
Collaborator Author

Both functions now output a data frame with columns "to", "from", "weight", "name.to", "name.from", which should be easily parsable by most network visualization tools.

@romainFr
Copy link
Collaborator Author

One thing that one still might want to add is the option to restrict the paths within a given ROI (or set of ROIs)

@romainFr
Copy link
Collaborator Author

Tests/examples should be added, but I'm going to merge as it's working/useful (and I'll start working off natverse/neuprintr branches from now on)

@romainFr romainFr merged commit fa38324 into natverse:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants